Custom metrics when viewing device

[lawik]

Adds custom metrics for display:

[lawik]

This is the more controversial part of #1796 and we don't have to merge it. I think it demos well. I think it is more useful than just showing our preferred ones. But not a hill I'll die on, made the PR as much to save the generic code since we may want it on the Health view :D

[joshk]

I'd be happy to merge this in if we are to combine it with an opt-in in the Product settings to show all or 'extended' metrics. (off by default)

Long term, I'd like to add a settings icon (cog) to the bottom right which gives you a way to customize what metrics you see on the device page.

[lawik]

Yeah, I am on board with some kind of product-wide setting to control what shows up. I'll noodle on something.

[nshoes]

I'd be happy to merge this in if we are to combine it with an opt-in in the Product settings to show all or 'extended' metrics.

+1 for me as well!

[lawik]

Want to do the setting thing. But more fiddly to get the database stuff set up. So for now removing the custom ones from the details view but including it in health. So now if you choose to look at health you get an overview of the latest data before all the graphs.

My Mac doesn't report health properly. But I essentially copy+pasted from details and then adjusted a little bit.

We can do the settings bit in a later PR. Let me know what you think :)

[joshk]

I love this! I had intended to add this to the health tab, thank you!

[joshk]

Ah, sorry, didn't see that it hadn't been pushed to the PR yet 😅

I know its a little none standard, I'm wondering if we remove the border and title and just have the stats.

We can also move the 'last updated' next to the period select buttons?

[lawik]

Did I forget to commit and just pushed air? Maybe a little..

[joshk]

I've made a small adjustment to your PR:

I removed the headers and link, and moved the 'last reported at' to the metrics header. I tried this without any border around the stats section, but i felt it wasn't keeping with the design.

I like this a bit better, and would be happy to merge it in.