Allow pages to be moved to slugs with Unicode characters in them #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge changes from master
nschneid
reviewed
Jun 18, 2020
|
|
||
| class WikiSlugField(forms.CharField): | ||
| """ | ||
| In future versions of Django, we might be able to define this field as | ||
| the default field directly on the model. For now, it's used in CreateForm. | ||
| """ | ||
|
|
||
| default_validators = [validators.validate_slug, validate_slug_numbers] | ||
| default_validators = [validate_slug_ss, validate_slug_numbers] |
There was a problem hiding this comment.
Why distinguish validate_slug_ss and validate_unicode_slug_adp here? If this is for article titles in general it shouldn't refer to supersenses and adpositions.
There was a problem hiding this comment.
If the distinction is Unicode vs. non-Unicode, will validators.validate_slug will continue to work on this line?
nschneid
reviewed
Jun 18, 2020
|
|
||
| def __init__(self, *args, **kwargs): | ||
| self.allow_unicode = kwargs.pop('allow_unicode', False) | ||
| if self.allow_unicode: | ||
| self.default_validators = [ | ||
| validators.validate_unicode_slug, | ||
| validate_unicode_slug_adp, |
There was a problem hiding this comment.
What does the validators.validate_unicode_slug regex look like? I think we just need to make it a tiny bit more permissive to allow modifier characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that I can move the Hindi pages to the Devanagari slugs. This fixes the regexes that govern moving pages.
(Has been tested locally but testing it again won't hurt)