Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewerplot element #3129

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add viewerplot element #3129

wants to merge 10 commits into from

Conversation

chungmin99
Copy link
Contributor

@chungmin99 chungmin99 commented May 8, 2024

  • make documentation
  • fix plotsize issue (needs refresh, otherwise the width >> panel width -- perhaps a viser race condition?)

return self.gui_handle.figure

@figure.setter
def figure(self, figure: go.Figure):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to automatically apply the dark mode+aspect to new figures as well, so that the user doesn't have to call dark_mode and aspect every time they update/change something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspect doesn't need to be set for new figures, but you're right about dark_mode. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addr'ed in ca04cbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants