Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw away non-tensor objects in TensorDataclass #2783

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Jan 18, 2024

I noticed after these lines:

metadata = {"fisheye_crop_radius": fisheye_crop_radius} if fisheye_crop_radius is not None else None
cameras = Cameras(
fx=fx,
fy=fy,
cx=cx,
cy=cy,
distortion_params=distortion_params,
height=height,
width=width,
camera_to_worlds=poses[:, :3, :4],
camera_type=camera_type,
metadata=metadata,
)

that cameras.metadata was {} even if the metadata variable was set to {'fisheye_crop_radius': 707.5}.

cc @sweeneychris maybe relevant to you?

@brentyi brentyi requested a review from kerrj January 18, 2024 06:42
@brentyi brentyi merged commit 99073eb into main Jan 19, 2024
3 checks passed
@brentyi brentyi deleted the brent/fix_tensor_dataclass_nontensor branch January 19, 2024 09:18
@brentyi brentyi mentioned this pull request Feb 23, 2024
@XLY43
Copy link

XLY43 commented Feb 27, 2024

Hi @brentyi would it work if I have custom fisheye data? I tried setting the fisheye_crop_radius manually but the radius still looks like half of the shorter dimension. Any tips would be great!

@brentyi
Copy link
Collaborator Author

brentyi commented Feb 27, 2024

@liuyuex97 I think it should work for custom data!

I saw you closed your issue, did you figure this out?

ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
…oject#2783)

* Don't throw away non-tensor objects in TensorDataclass

* Update test_tensor_dataclass.py

---------

Co-authored-by: Justin Kerr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants