Don't throw away non-tensor objects in TensorDataclass #2783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after these lines:
nerfstudio/nerfstudio/data/dataparsers/nerfstudio_dataparser.py
Lines 291 to 303 in 368c9ec
that
cameras.metadata
was{}
even if themetadata
variable was set to{'fisheye_crop_radius': 707.5}
.cc @sweeneychris maybe relevant to you?