Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project gaussians: adding numerical tests, resolving gradient bug #85

Closed
wants to merge 6 commits into from

Conversation

vye16
Copy link
Collaborator

@vye16 vye16 commented Dec 16, 2023

  • added numerical tests for forward and backward passes against autograd on torch_impl in tests/test_project_gaussians.py
  • fixed a gradient bug in projection. NOTE this changes the interface for the ProjectGaussians function, which now expects viewmat and projmat, rather than viewmat and the full matrix ofprojmat * viewmat as it did before.
  • forward pass matches up to 1e-5 precision, backward pass matches up to 5e-4 precision.

@vye16 vye16 marked this pull request as draft December 16, 2023 02:57
@liruilong940607
Copy link
Collaborator

All looks great. I think the change on the interface of ProjectGaussians makes sense but we might need to consider backward compatibility. Is there a way to find out if the user is passing in the fullmat as before and raise a warning (preferable option)? Another option is to remain the API unchanged but compute the projmat from fullmat and viewmat.

@kerrj kerrj closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants