Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Autodestroy CI VMs after two hours" #283

Closed
wants to merge 1 commit into from

Conversation

radoslawc
Copy link
Collaborator

Reverts #263

Seems like preemptive VM provisioning might have negative impact on e2e tests stability and performance

https://cloud.google.com/compute/docs/instances/create-use-preemptible

Preemptible VMs are available at up to a 60-91% discount compared to the price of standard VMs. However, Compute Engine might stop (preempt) these VMs if it needs to reclaim those resources for other tasks. Preemptible VMs always stop after 24 hours. Preemptible VMs are recommended only for fault-tolerant applications that can withstand VM preemption. Make sure your application can handle preemptions before you decide to create a preemptible VM. To understand the risks and value of preemptible VMs, read the preemptible VM instances documentation.

Caution: Preemptible VMs are not covered by any Service Level Agreement and are excluded from the Compute Engine SLA. For more information, see limitations of preemptible VM instances

Copy link
Contributor

nephio-prow bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from radoslawc by writing /assign @radoslawc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@electrocucaracha
Copy link
Member

@radoslawc reverting this change will require that someone constantly monitors some leftovers in the CI accessing to the GCP project.

@liamfallon
Copy link
Member

/test e2e-free5gc-ubuntu-focal

@liamfallon
Copy link
Member

/test e2e-oai-ubuntu-jammy
/test e2e-oai-fedora-34

@radoslawc
Copy link
Collaborator Author

/test e2e-oai-ubuntu-jammy

1 similar comment
@liamfallon
Copy link
Member

/test e2e-oai-ubuntu-jammy

Copy link
Contributor

nephio-prow bot commented Jul 6, 2024

@radoslawc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
e2e-free5gc-fedora-34 8d1ef34 link false /test e2e-free5gc-fedora-34
e2e-free5gc-ubuntu-focal 8d1ef34 link true /test e2e-free5gc-ubuntu-focal
e2e-oai-fedora-34 8d1ef34 link false /test e2e-oai-fedora-34
e2e-oai-ubuntu-jammy 8d1ef34 link true /test e2e-oai-ubuntu-jammy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@radoslawc
Copy link
Collaborator Author

ported to 282

@radoslawc radoslawc closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants