Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert optional tags in paremeterRef #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

revert optional tags in paremeterRef #54

wants to merge 2 commits into from

Conversation

henderiw
Copy link
Contributor

fixed tags in parameterRef
revert the omit empty in the parameterRef

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from henderiw by writing /assign @henderiw in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot requested review from s3wong and tliron October 13, 2023 15:00
@henderiw
Copy link
Contributor Author

#54

@henderiw
Copy link
Contributor Author

/test presubmit-api-fossology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephthaliath josephthaliath josephthaliath left review comments

@s3wong s3wong Awaiting requested review from s3wong

@tliron tliron Awaiting requested review from tliron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henderiw @josephthaliath