Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageConfig types. #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denysaleksandrov
Copy link
Member

Per the discussion here, ImageConfig should be part of api repo.

@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot requested review from s3wong and tliron May 11, 2023 15:32
@henderiw
Copy link
Contributor

Do we really need a CR for this or can this be a config map ?

@denysaleksandrov
Copy link
Member Author

Do we really need a CR for this or can this be a config map ?

Yes, we can do a config-map or annotation or even add an image as part of the spec.
But the idea was to have a CR that would contain images for all xNF functions and the NF controller should get images from it. We can even reconcile xNF controllers in case ImageConifg CR changes.

Here is an example manifest:

apiVersion: workload.nephio.org/v1alpha1
kind: ImageConfig
metadata:
  name: free5gc-images
  namespace: free5gc-extension
spec:
  imagePaths:
    upf: towards5gs/free5gc-upf:v3.1.1
    smf: towards5gs/free5gc-smf:v3.1.1
    amf: towards5gs/free5gc-amf:v3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants