Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.3 support #60

Merged
merged 5 commits into from
Dec 11, 2014
Merged

python 3.3 support #60

merged 5 commits into from
Dec 11, 2014

Conversation

skirsdeda
Copy link
Contributor

I have found that the only obstacle to use djangocms-blog with python 3.3 is django-select2 dependency. It has to be changed to django-select2-Py3. For some strange reason they do not support python 2-3 compatibility in the same package.
I have changed the dependency in setup.py to check running python version and select django-select2 package accordingly. Seems to work but I am not sure if this is the best solution in this case.

@skirsdeda
Copy link
Contributor Author

Added edc74b6 to fix initial django migration which fails otherwise.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9254d3d on skirsdeda:develop into 003be58 on nephila:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling edc74b6 on skirsdeda:develop into 003be58 on nephila:develop.

@yakky
Copy link
Member

yakky commented Dec 10, 2014

Great!
Please add 3.4 too to the classifiers.
I want to check if there is a better solution to express the conditional dependency

@yakky yakky self-assigned this Dec 10, 2014
@yakky
Copy link
Member

yakky commented Dec 11, 2014

@skirsdeda Thanks, great job!

yakky added a commit that referenced this pull request Dec 11, 2014
@yakky yakky merged commit 567e1d0 into nephila:develop Dec 11, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1448d8f on skirsdeda:develop into 003be58 on nephila:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants