-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX Rewrite of internal node properties in FlowQueries #64
Conversation
Just wondering, this is obviously wrong but we need both, right? you could have |
We have always two cases: The code was already trying to handle that, but unfortunatelly, the regex we used was missing the |
tests/ContentRepository90/Rules/FusionNodeHiddenInIndexRector/Fixture/some_file.fusion.inc
Show resolved
Hide resolved
src/ContentRepository90/Rules/FusionNodeHiddenInIndexRector.php
Outdated
Show resolved
Hide resolved
Thanks for your input @kdambekalns. I've changed it. |
src/ContentRepository90/Rules/FusionNodeHiddenInIndexRector.php
Outdated
Show resolved
Hide resolved
src/ContentRepository90/Rules/FusionNodeHiddenInIndexRector.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much and sorry for all the requested adjustments
Also fixed existing and added missing tests.