Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX Rewrite of internal node properties in FlowQueries #64

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Jun 2, 2024

Also fixed existing and added missing tests.

  • _contextPath
  • _depth
  • _hiddenInIndex
  • _path

@kitsunet
Copy link
Member

kitsunet commented Jun 2, 2024

Just wondering, this is obviously wrong but we need both, right? you could have q(node).property('_depth_) as well as node._depth or do we cover that elsewhere?

@dlubitz
Copy link
Contributor Author

dlubitz commented Jun 2, 2024

We have always two cases: node.depth and also q(node).property('depth')

The code was already trying to handle that, but unfortunatelly, the regex we used was missing the q(...) part, so we tried to replace all node.property(...) which is actally not valid.

@dlubitz dlubitz requested a review from kdambekalns June 13, 2024 08:00
@dlubitz
Copy link
Contributor Author

dlubitz commented Jun 13, 2024

Thanks for your input @kdambekalns. I've changed it.

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much and sorry for all the requested adjustments

@dlubitz dlubitz merged commit ca5ad77 into main Jun 17, 2024
2 checks passed
@dlubitz dlubitz deleted the bugfix-internal-node-properties-in-flowquery branch June 17, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants