Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Remove CreateContentContextTrait and add todos #116

Merged
merged 2 commits into from
Dec 23, 2024
Merged

FEATURE: Remove CreateContentContextTrait and add todos #116

merged 2 commits into from
Dec 23, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Dec 18, 2024 •
edited
Loading

Fixes: #101

Depends on #115

@dlubitz dlubitz self-assigned this Dec 18, 2024
@dlubitz dlubitz force-pushed the feature/create-content-context-trait branch from 5770389 to 1251a24 Compare December 19, 2024 11:17
mhsdesign
mhsdesign approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one that we migrate this helper trait which was somehow api and used after all :D

are we also declaring that \Neos\ContentRepository\Domain\Service\ContextFactory::create is removed?

@dlubitz
Copy link
Contributor Author

dlubitz commented Dec 23, 2024

are we also declaring that \Neos\ContentRepository\Domain\Service\ContextFactory::create is removed?

No, this will be tackled here: #120

@dlubitz dlubitz merged commit 411fdfc into main Dec 23, 2024
4 checks passed
@dlubitz dlubitz deleted the feature/create-content-context-trait branch December 23, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees

@dlubitz dlubitz

Labels
None yet
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateContentContextTrait is not supported anymore
2 participants
@dlubitz @mhsdesign