BUGFIX: Forgiving I18nRegistry.translate for strings with colons and undefined
#3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following node type configuration
```yaml
placeholder: 'ClientEval: node.properties.tagName'
```
currently yields an error which is caught by the error boundary for properties:
> Error: TranslationAddress must adhere to format "{packageKey}:{sourceName}:{transUnitId}". Got "ClientEval: node.properties.tagName" instead.
The newly added strictness in neos#3804 introduces this regression here.
Previously the function `getTranslationAddress` would just attempt to spit a string and expect three items to be returned:
https://github.com/neos/neos-ui/blob/2cecfcf136aafcd9e3f72537f513eb81b01e993b/packages/neos-ui-i18n/src/registry/I18nRegistry.js#L7
The deconstruction would already cause an error in PHP but not in JavaScript:
```
const [packageKey, sourceName, id] = 'ClientEval: node.properties.tagName'.split(':')
```
Returns
```
packageKey: "ClientEval"
sourceName: " node.properties.tagName"
id: undefined
```
The previous forgiveness needs to be reintroduced as its easy to create errors with strings containing colons at any position which is definitely likely for placeholders. Imagine: `placeholder: "The title of the blog:"`.
…e()` the use of ``` i18nRegistry.translate(ui?.help?.message) ``` in https://github.com/neos/neos-ui/blob/a60961417e7ad49a22b75d48dbe4b2542a25ae5b/packages/neos-ui/src/Containers/Modals/SelectNodeType/nodeTypeItem.js#L60 brings the Ui currently to a fatal crash: > Message: undefined is not an object (evaluating 'string5.split') This change reintroduces the old behaviour by returning a possible fallback instead or `undefined`.
mhsdesign
changed the title
I18nRegistry.translate for strings with colonsI18nRegistry.translate for strings with colons and undefined
|
This could also crash the whole ui in case a string contains a colon in the help message for example for the neos demo: 
And in 5520eb4 i fixed that passing no id does not crash as well. Ill merge this as i could not find a reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following node type configuration
currently yields an error which is caught by the error boundary for properties:
The newly added strictness in #3804 introduces this regression here.
Previously the function
getTranslationAddresswould just attempt to spit a string and expect three items to be returned:neos-ui/packages/neos-ui-i18n/src/registry/I18nRegistry.js
Line 7 in 2cecfcf
The deconstruction would already cause an error in PHP but not in JavaScript:
Returns
The previous forgiveness needs to be reintroduced as its easy to create errors with strings containing colons at any position which is definitely likely for placeholders. Imagine:
placeholder: "The title of the blog:".What I did
How I did it
How to verify it