FEATURE: Refactor publication and discarding endpoints #3752

nezaniel · 2024-03-14T17:05:57Z

This implements explicit endpoints for publishing and discarding sites or documents, adjusting Neos' behavior to the ESCR.

(see also: neos/neos-development-collection#4943)

Otherwise Flow's reflection gets in the way of converting the request body to array, because it doesn't know how to handle type `array<string,string>`.

…ish/discard actions

…rdDialog

…gesToBeDiscarded` in DiscardDialog

…verywhere

… discarded

grebaldi · 2024-03-19T10:39:46Z

PHP linting check will be fixed once FEATURE: Highlevel Workspace API neos-development-collection#4943 has been merged
JS unit tests will be green once TASK: Remove obsolote apply button from dateInput snapshot #3757 has been upmerged to 9.0
E2E tests are green, because of 3a06560 - We need to revert this commit before merging!

This commit MUST be removed before merging PR #3752

see: neos/neos-development-collection@2a86e89

…Controller accordingly

…ption" This reverts commit 820942f.

mhsdesign · 2024-03-29T15:17:22Z

Thanks for all the adjustments and discussions so far. It seems the mutations are now handled by the Neos Workspace but we dont use the new Workspace::countChangesInSite api. Should we do this in a followup or later :D?

grebaldi · 2024-03-29T15:46:09Z

@mhsdesign:

Thanks for all the adjustments and discussions so far. It seems the mutations are now handled by the Neos Workspace but we dont use the new Workspace::countChangesInSite api. Should we do this in a followup or later :D?

Definitely later. Currently, we need the actual changes in the UI to calculate dirty-state in various places. The new API doesn't solve this for us yet, but that's an implementation detail and can be adjusted later down the line. We need to take care of conflict resolution first.

mhsdesign · 2024-04-03T14:47:28Z

Classes/Controller/BackendServiceController.php

    {
+        /** @todo send from UI */


todo remove todo, or later

mhsdesign

Thanks for the change i will run the Neos Ui e2e locally and then i suppose we can merge this.

grebaldi · 2024-04-03T17:00:54Z

Just a reminder:

FEATURE: Highlevel Workspace API neos-development-collection#4943 should be merged first
3a06560 must be reverted before this one gets merged

mhsdesign · 2024-04-03T18:24:47Z

Locally all tests pass, except an unrelated unit test failure that should be fixed after an upmerge. Ill push also a commit to fix the silly ci (sorry i meant style ci)

mhsdesign · 2024-04-05T11:46:06Z

reopen to trigger ci

mhsdesign · 2024-04-05T19:03:47Z

Huh e2e still fail

Fatal error: Cannot redeclare Neos\Neos\Domain\Workspace\Workspace::getCurrentContentStreamId() in /home/circleci/app/Packages/Neos/Neos.Neos/Classes/Domain/Workspace/Workspace.php on line 131

also on 9.0 after merge ...

mhsdesign · 2024-11-30T20:55:45Z

Classes/Controller/BackendServiceController.php

-                $nodeIdentifiersToPublish[] = new NodeIdToPublishOrDiscard(
-                    $nodeAddress->nodeAggregateId,
-                    $nodeAddress->dimensionSpacePoint
-                );


FYI, as we dont use the node address from the Neos Ui here anymore and their dimension we accidentally trashed partial publishing with respect to dimensions.

But this might be okay as discussed :D

nezaniel marked this pull request as draft March 14, 2024 17:06

github-actions bot added the 9.0 label Mar 14, 2024

nezaniel assigned nezaniel and grebaldi Mar 14, 2024

nezaniel mentioned this pull request Mar 14, 2024

FEATURE: Highlevel Workspace API neos/neos-development-collection#4943

Merged

grebaldi added 5 commits March 17, 2024 17:21

!!!TASK: Refactor publication and discarding endpoints

c7ce636

TASK: Re-add flow annotations in backend service controller

75a290e

TASK: Add new publish/discard enpoints to Routes.yaml

6958ebc

TASK: Add new publish/discard routes to backend connector

6c8be6b

TASK: Adjust Workspaces redux store to new publish/discard semantics

b01269c

grebaldi force-pushed the publishingBonanza branch from e624b53 to b01269c Compare March 17, 2024 16:22

grebaldi added 9 commits March 18, 2024 14:40

TASK: Wrap publishing endpoint invokations in command object

7eafb3f

TASK: Use @phpstan-param annotation for publish/discard actions

18beaa6

Otherwise Flow's reflection gets in the way of converting the request body to array, because it doesn't know how to handle type `array<string,string>`.

TASK: Convert given NodeAddresses to NodeAggregateIds in all publ…

334f1d5

…ish/discard actions

TASK: Implement new publish workflow in redux-saga

c2d30de

TASK: Adjust prop type in discard dialog

496a471

BUGFIX: Fix reference to publish/discard-scope in @connect of Disca…

7665b36

…rdDialog

BUGFIX: Read length of publishable nodes to calculate `numberOfChan…

41c37b0

…gesToBeDiscarded` in DiscardDialog

TASK: Turn PublishDiscardScope into enum and fix typo in references e…

b961b47

…verywhere

TASK: Introduce PublishDiscardMode

1945ec5

mhsdesign self-requested a review March 18, 2024 20:11

grebaldi added 4 commits March 18, 2024 21:31

TASK: Use site as removal attachment point if document is removed

768dd8d

TASK: Implement new discard workflow in redux-saga

34f36ec

TASK: Navigate to closest other document if current document has been…

8dc7616

… discarded

TASK: Fix linting errors

4c4185c

TASK: Temporarily add patch for neos/neos-development-collection#4943

3a06560

This commit MUST be removed before merging PR #3752

grebaldi changed the title ~~Refactor publication and discarding endpoints~~ FEATURE: Refactor publication and discarding endpoints Mar 19, 2024

grebaldi marked this pull request as ready for review March 19, 2024 11:32

github-actions bot added the Feature Label to mark the change as feature label Mar 19, 2024

grebaldi and others added 8 commits March 22, 2024 11:12

TASK: Update command and method names according to upstream changes

a3c0588

see: neos/neos-development-collection@2a86e89

TASK: Adjust publishing action names to match the Neos.Neos API

6368826

TASK: Consider nullability of nodeType in Remove change object

2a4c5f9

Adjust to new workspace model

cb11477

Introduce ChangeTargetWorkspace

fabc40a

TASK: Add SyncWorkspace application command and adjust BackendService…

de64755

…Controller accordingly

Adjust BackendServiceController to WorkspaceRebaseFailed exception

820942f

Revert "Adjust BackendServiceController to WorkspaceRebaseFailed exce…

cc11ac1

…ption" This reverts commit 820942f.

Bernhard Schmitt added 3 commits April 2, 2024 18:32

Merge branch '9.0' into publishingBonanza

17aa6a7

Adjust to Neos dev distribution adjustments

5a0a269

Adjust to exposed rebase error handling strategy

98b5ac2

mhsdesign reviewed Apr 3, 2024

View reviewed changes

Classes/Controller/BackendServiceController.php

{

/** @todo send from UI */

Copy link

Member

mhsdesign Apr 3, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo remove todo, or later

mhsdesign approved these changes Apr 3, 2024

View reviewed changes

mhsdesign and others added 4 commits April 3, 2024 20:25

TASK: Fix style ci

5f9681d

TASK: Rename WorkspaceFactory to WorkspaceProvider

3937bf1

TASK: Rename to retrieveForWorkspaceName

5d69f43

Adjust to new workspace provider methods

8e15504

mhsdesign closed this Apr 5, 2024

mhsdesign reopened this Apr 5, 2024

mhsdesign merged commit 1930801 into 9.0 Apr 5, 2024
10 of 13 checks passed

mhsdesign deleted the publishingBonanza branch April 5, 2024 18:24

grebaldi mentioned this pull request Apr 11, 2024

EPIC: Neos 9.0 Conflict Resolution #3742

Open

3 tasks

mhsdesign reviewed Nov 30, 2024

View reviewed changes

mhsdesign mentioned this pull request Nov 30, 2024

PartialPublish / Discard vs Content Dimensions neos/neos-development-collection#5387

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FEATURE: Refactor publication and discarding endpoints #3752

FEATURE: Refactor publication and discarding endpoints #3752

nezaniel commented Mar 14, 2024 •

edited

Loading

grebaldi commented Mar 19, 2024 •

edited

Loading

mhsdesign commented Mar 29, 2024

grebaldi commented Mar 29, 2024

mhsdesign Apr 3, 2024 •

edited

Loading

mhsdesign left a comment

grebaldi commented Apr 3, 2024

mhsdesign commented Apr 3, 2024

mhsdesign commented Apr 5, 2024

mhsdesign commented Apr 5, 2024

mhsdesign Nov 30, 2024

FEATURE: Refactor publication and discarding endpoints #3752

FEATURE: Refactor publication and discarding endpoints #3752

Conversation

nezaniel commented Mar 14, 2024 • edited Loading

grebaldi commented Mar 19, 2024 • edited Loading

mhsdesign commented Mar 29, 2024

grebaldi commented Mar 29, 2024

mhsdesign Apr 3, 2024 • edited Loading

Choose a reason for hiding this comment

mhsdesign left a comment

Choose a reason for hiding this comment

grebaldi commented Apr 3, 2024

mhsdesign commented Apr 3, 2024

mhsdesign commented Apr 5, 2024

mhsdesign commented Apr 5, 2024

mhsdesign Nov 30, 2024

Choose a reason for hiding this comment

nezaniel commented Mar 14, 2024 •

edited

Loading

grebaldi commented Mar 19, 2024 •

edited

Loading

mhsdesign Apr 3, 2024 •

edited

Loading