BUGFIX: reimplement appendExceedingArguments for preview route
#5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reintroduces
```yaml
appendExceedingArguments: true
```
for the preview route so that uris could still build via plain fusion or flows `Neos\Flow\Mvc\Routing\UriBuilder`
```
previewAction = Neos.Fusion:ActionUri {
request = ${request.mainRequest}
package = 'Neos.Neos'
controller = 'Frontend\\\Node'
action = 'preview'
arguments = ${{node: someNodeAddress}}
}
```
This was initially reverted via 2c4670c in neos#4892 in effort to get slowly rid of the `appendExceedingArguments` ugliness. But in the Dresden sprint '24 was considered to big of a change for now, especially as there is no alternative to build the uris in fusion without the `queryParameters` option introduced for the `Neos.Fusion:ActionUri` which will only be part of: neos#3914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #5132)
This reintroduces
for the preview route so that uris could still build via plain fusion or flows
Neos\Flow\Mvc\Routing\UriBuilderThis was initially reverted via 2c4670c in #4892 in effort to get slowly rid of the
appendExceedingArgumentsugliness. But in the Dresden sprint '24 was considered too big of a change for now, especially as there is no alternative to build the uris in fusion without thequeryParametersoption introduced for theNeos.Fusion:ActionUriwhich will only be part of: #3914