Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Mark all affected dimension space points as changed on node move #5393

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Dec 3, 2024

Fixes partially #4614, that all affected dimensions of the move are published.

On publish we will actually publish all dimensions (depends on #5385)

@dlubitz dlubitz self-assigned this Dec 3, 2024
@github-actions github-actions bot added the Bug label Dec 3, 2024
@dlubitz dlubitz requested a review from kitsunet December 3, 2024 15:58
@github-actions github-actions bot added the 9.0 label Dec 3, 2024
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should do well with #5385

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though before we merge this we should have #5385 ready as of right now the bug only doesn appear because of the accident that the Neos ui does not publish dimensions.

Also while it was my idea to say that we should mark all affected DSP on node move, we dont do that for remove node or set properties, there we only use the origin dsp.

Maybe its still a good choice to vary here from the concept but we should discuss this in a bigger round (shortly Friday)

@mhsdesign
Copy link
Member

So i thought about this again, maybe its totally fine to only mark the "real" node variants as changed - like that we only mark set properties in the origin dimension and NOT in the fallbacks. That would especially be sensible as the new publish dialog (#5387) should only warn if the change affects other dimension if NOT expected. A fallback is common behaviour.

The question is how do we do that for move node? The idea to make it from user side behave correctly - (and only show the warn dialog if expected) - we would need to mark only dimensions as affected which are not a fallback. (or delay that for the actual change calculation)

On the other hand maybe it will just be like this for a first draft. Moving a content element will be scattered and NOT show the warning, while only moving documents will show the warning and it might be event okay to do so - even for fallbacks.

Having the warning for every change properties because of their fallbacks would be bad ux ....

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, the problem here is that the change projection does not want to accept that there are edge operations and node operations ^^ (while move is a an edge operation)

with #5385 (comment) the information is purely costmetic and its better to mark it in all dimensions that only in an arbitrary dimension.

Only document node moves will be carried out in multiple dimensions, and for that it might be okay to point out a warning even if it is just the fallback node that is moved too.

@mhsdesign mhsdesign merged commit 84c0e70 into 9.0 Dec 12, 2024
11 checks passed
@mhsdesign mhsdesign deleted the 90/bugfix/mark-all-affected-dimensions-on-move branch December 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants