-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Mark all affected dimension space points as changed on node move #5393
BUGFIX: Mark all affected dimension space points as changed on node move #5393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This should do well with #5385
Neos.Neos/Classes/PendingChangesProjection/ChangeProjection.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Henry Schultz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though before we merge this we should have #5385 ready as of right now the bug only doesn appear because of the accident that the Neos ui does not publish dimensions.
Also while it was my idea to say that we should mark all affected DSP on node move, we dont do that for remove node or set properties, there we only use the origin dsp.
Maybe its still a good choice to vary here from the concept but we should discuss this in a bigger round (shortly Friday)
So i thought about this again, maybe its totally fine to only mark the "real" node variants as changed - like that we only mark set properties in the origin dimension and NOT in the fallbacks. That would especially be sensible as the new publish dialog (#5387) should only warn if the change affects other dimension if NOT expected. A fallback is common behaviour. The question is how do we do that for move node? The idea to make it from user side behave correctly - (and only show the warn dialog if expected) - we would need to mark only dimensions as affected which are not a fallback. (or delay that for the actual change calculation) On the other hand maybe it will just be like this for a first draft. Moving a content element will be scattered and NOT show the warning, while only moving documents will show the warning and it might be event okay to do so - even for fallbacks. Having the warning for every change properties because of their fallbacks would be bad ux .... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed, the problem here is that the change projection does not want to accept that there are edge operations and node operations ^^ (while move is a an edge operation)
with #5385 (comment) the information is purely costmetic and its better to mark it in all dimensions that only in an arbitrary dimension.
Only document node moves will be carried out in multiple dimensions, and for that it might be okay to point out a warning even if it is just the fallback node that is moved too.
Fixes partially #4614, that all affected dimensions of the move are published.
On publish we will actually publish all dimensions (depends on #5385)