Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Check if site node exists in context before running policy check #4649

Closed
wants to merge 2 commits into from

Conversation

tdausner
Copy link
Contributor

Bugfix issues/4625

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 7.3 label Oct 28, 2023
@kdambekalns kdambekalns changed the title Bugfix issues/4625 BUGFIX: Always show site nodes in backend, even if hidden Nov 2, 2023
@github-actions github-actions bot added the Bug label Nov 2, 2023
@mhsdesign mhsdesign changed the title BUGFIX: Always show site nodes in backend, even if hidden BUGFIX: Check if site node exists in context before running policy check Feb 5, 2024
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops this seems to be a duplicate of this fix #4269

@mhsdesign
Copy link
Member

This fix seems to be incomplete so i will close this in favour of #4269 thank you still for your efforts :D

It basically fixes, that the backend will still be usable, but the site won't show up in the return val $sites, although you might be allowed to access it, because the node is in another dimension than the default.

@mhsdesign mhsdesign closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants