TASK: Add site nodeName to testcases to avoid relying on invalid beha…

…vior The projection detects site nodes that should have an empty path by verifying that the parent is a root node and they have a nodeName.
neos · Dec 22, 2024 · d9772d3 · d9772d3
1 parent dd3ff9d
commit d9772d3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/Neos.Neos/Tests/Behavior/Features/FrontendRouting/NodeCreationEdgeCases.feature b/Neos.Neos/Tests/Behavior/Features/FrontendRouting/NodeCreationEdgeCases.feature
@@ -36,6 +36,7 @@ Feature: Test cases for node creation edge cases
       | nodeTypeName              | "Neos.Neos:Site"         |
       | parentNodeAggregateId     | "lady-eleonode-rootford" |
       | originDimensionSpacePoint | {"example":"source"}     |
+      | nodeName                  | "site"                   |
     And the following CreateNodeAggregateWithNode commands are executed:
       | nodeAggregateId      | nodeName          | parentNodeAggregateId | succeedingSiblingNodeAggregateId | nodeTypeName       | initialPropertyValues          |
     # Let's prepare some siblings to check orderings. Also, everything gets better with siblings.

diff --git a/Neos.Neos/Tests/Behavior/Features/FrontendRouting/NodeVariationEdgeCases.feature b/Neos.Neos/Tests/Behavior/Features/FrontendRouting/NodeVariationEdgeCases.feature
@@ -36,6 +36,7 @@ Feature: Test cases for node variation edge cases
       | nodeTypeName              | "Neos.Neos:Site"         |
       | parentNodeAggregateId     | "lady-eleonode-rootford" |
       | originDimensionSpacePoint | {"example":"source"}     |
+      | nodeName                  | "site"                   |
     And the command CreateNodeVariant is executed with payload:
       | Key             | Value                |
       | nodeAggregateId | "shernode-homes"     |
@@ -135,6 +136,7 @@ Feature: Test cases for node variation edge cases
       | nodeTypeName              | "Neos.Neos:Site"          |
       | parentNodeAggregateId     | "lady-eleonode-rootford"  |
       | originDimensionSpacePoint | {"example":"rootGeneral"} |
+      | nodeName                  | "site"                    |
     And the following CreateNodeAggregateWithNode commands are executed:
       | nodeAggregateId      | originDimensionSpacePoint | nodeName          | parentNodeAggregateId | succeedingSiblingNodeAggregateId | nodeTypeName       | initialPropertyValues          |
     # Let's create some siblings, both in source and target, to check ordering
@@ -225,6 +227,7 @@ Feature: Test cases for node variation edge cases
       | nodeTypeName              | "Neos.Neos:Site"         |
       | parentNodeAggregateId     | "lady-eleonode-rootford" |
       | originDimensionSpacePoint | {"example":"source"}     |
+      | nodeName                  | "site"                   |
     And the following CreateNodeAggregateWithNode commands are executed:
       | nodeAggregateId      | nodeName          | parentNodeAggregateId | succeedingSiblingNodeAggregateId | nodeTypeName       | initialPropertyValues          |
     # Let's create our test subject...

diff --git a/Neos.Neos/Tests/Behavior/Features/FrontendRouting/PartialPublish.feature b/Neos.Neos/Tests/Behavior/Features/FrontendRouting/PartialPublish.feature
@@ -36,6 +36,7 @@ Feature: Test cases for partial publish to live and uri path generation
       | nodeTypeName              | "Neos.Neos:Site"         |
       | parentNodeAggregateId     | "lady-eleonode-rootford" |
       | originDimensionSpacePoint | {"example":"source"}     |
+      | nodeName                  | "site"                   |
     And the command CreateWorkspace is executed with payload:
       | Key                       | Value                    |
       | workspaceName             | "myworkspace"            |
@@ -49,7 +50,7 @@ Feature: Test cases for partial publish to live and uri path generation
       | nodeTypeName              | "Neos.Neos:Document"      |
       | parentNodeAggregateId     | "shernode-homes"          |
       | originDimensionSpacePoint | {"example":"source"}      |
-      | properties                | {"uriPathSegment": "just"}|
+      | initialPropertyValues     | {"uriPathSegment": "just"}|
       | workspaceName             | "myworkspace"             |
     And the command PublishIndividualNodesFromWorkspace is executed with payload:
       | Key                       | Value                      |
@@ -65,4 +66,4 @@ Feature: Test cases for partial publish to live and uri path generation
       | "65901ded4f068dac14ad0dce4f459b29" | ""         | "lady-eleonode-rootford"                                     | "lady-eleonode-rootford" | null                     | null                     | null                      | "Neos.Neos:Sites"    |
       | "fbe53ddc3305685fbb4dbf529f283a0e" | ""         | "lady-eleonode-rootford"                                     | "lady-eleonode-rootford" | null                     | null                     | null                      | "Neos.Neos:Sites"    |
       | "65901ded4f068dac14ad0dce4f459b29" | ""         | "lady-eleonode-rootford/shernode-homes"                      | "shernode-homes"         | "lady-eleonode-rootford" | null                     | null                      | "Neos.Neos:Site"     |
-      | "65901ded4f068dac14ad0dce4f459b29" | ""         | "lady-eleonode-rootford/shernode-homes/justsomepage"         | "justsomepage"           | "shernode-homes"         | null                     | null                      | "Neos.Neos:Document"     |
+      | "65901ded4f068dac14ad0dce4f459b29" | "just"     | "lady-eleonode-rootford/shernode-homes/justsomepage"         | "justsomepage"           | "shernode-homes"         | null                     | null                      | "Neos.Neos:Document"     |
diff --git a/Neos.Neos/Tests/Behavior/Features/FrontendRouting/UnknownNodeTypes.feature b/Neos.Neos/Tests/Behavior/Features/FrontendRouting/UnknownNodeTypes.feature
@@ -39,6 +39,7 @@ Feature: Basic routing functionality (match & resolve nodes with unknown types)
       | nodeTypeName                | "Neos.Neos:Test.Routing.Page" |
       | parentNodeAggregateId       | "lady-eleonode-rootford"      |
       | nodeAggregateClassification | "regular"                     |
+      | nodeName                    | "site"                        |
     And the event NodeAggregateWithNodeWasCreated was published with payload:
       | Key                         | Value                                                                 |
       | workspaceName               | "live"                                                                |