TASK: Correctly mark nullable method parameters as nullable #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2025
markusguenther
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3427
This PR will correctly mark implicit nullable types as nullable, which will remove deprecation warnings in PHP 8.4.
I've used rector to migrate all occurrences.
https://getrector.com/rule-detail/explicit-nullable-param-type-rector
See also for Neos: neos/neos-development-collection#5433
Note: We should run the rector migration again on 9.0 after upmerging this PR
Thanks to @Benjamin-K for bringing this up and providing the first PR (#3427).