Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Handle non-integer error codes in throwabe FileStorage #3416

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

kdambekalns
Copy link
Member

@kdambekalns kdambekalns commented Nov 15, 2024

This will no longer swallow certain error codes but instead emit them in the message.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable and logical. :)

@kdambekalns kdambekalns merged commit 2d1c50f into neos:8.3 Jan 27, 2025
11 checks passed
@kdambekalns kdambekalns deleted the task/handle-non-int-error-codes branch January 27, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants