FEATURE: Add DecendantOfNodetype Condition Generator #3403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
vcg-development
changed the title
|
Hi there, welcome and thank you for your contribution. As this is a FEATURE it should only go into the next following minor or major release, as 8.3 is already released, this would be 8.4 now which is not yet released. So I will adjust the PR to target 8.4 instead. |
vcg-development
force-pushed
the
decendant-of-nodetype
branch
from
9d04e51 to
5f4e133
Compare
vcg-development
force-pushed
the
decendant-of-nodetype
branch
from
5f4e133 to
9e18735
Compare
skurfuerst
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Hey,
Reviewed in neos/neos-development-collection#5291 (review) :) -> let's discuss there.
All the best,
Sebastian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the DecendantOfNodetypeConditionGenerator which will be used by the isDescendantOfNodetype privilege target matcher in the neos-development-collection repository.
Review instructions
A test for the isDescendantOfNodetype privilege target matcher can be found in the commit in the "neos-development-collection" repository.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions