Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use reusable workflow for MacOs build #9889

Merged
merged 43 commits into from
Jan 7, 2025

Conversation

fedordikarev
Copy link
Contributor

@fedordikarev fedordikarev commented Nov 25, 2024

Closes: https://github.com/neondatabase/cloud/issues/17784

Problem

Currently, we run the whole CI pipeline for any changes. It's slow and expensive.

Suggestion

Starting with MacOs builds:

  • check what files were changed
  • rebuild only needed parts
  • reuse results from previous builds when available
  • run builds in parallel when possible

@fedordikarev fedordikarev added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

7227 tests run: 6875 passed, 0 failed, 352 skipped (full report)


Flaky tests (2)

Postgres 16

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Code coverage* (full report)

  • functions: 31.2% (8413 of 26961 functions)
  • lines: 48.0% (66801 of 139225 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
73d1824 at 2025-01-07T18:57:08.104Z :recycle:

@fedordikarev fedordikarev marked this pull request as ready for review December 17, 2024 08:16
@fedordikarev fedordikarev requested a review from a team as a code owner December 17, 2024 08:16
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we run the whole CI pipeline for any changes. It's slow and expensive.

I wonder what the numbers are? For cases with full cache and no cache

.github/file-filters.yaml Outdated Show resolved Hide resolved
@fedordikarev fedordikarev requested a review from bayandin January 6, 2025 09:23
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

.github/file-filters.yaml Outdated Show resolved Hide resolved
.github/workflows/build-macos.yml Show resolved Hide resolved
fedordikarev and others added 2 commits January 7, 2025 18:58
Co-authored-by: Alexander Bayandin <[email protected]>
Co-authored-by: Alexander Bayandin <[email protected]>
@fedordikarev fedordikarev added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 43a5e57 Jan 7, 2025
86 checks passed
@fedordikarev fedordikarev deleted the feat/ci_workflow_build_macos_3 branch January 7, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants