Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: exclude archived timelines from freeze+flush on shutdown #10594

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 30, 2025

Problem

If offloading races with normal shutdown, we get a "failed to freeze and flush: cannot flush frozen layers when flush_loop is not running, state is Exited". This is harmless but points to it being quite strange to try and freeze and flush such a timeline. flushing on shutdown for an archived timeline isn't useful.

Related: #10389

Summary of changes

  • During Timeline::shutdown, ignore ShutdownMode::FreezeAndFlush if the timeline is archived

@jcsp jcsp requested a review from a team as a code owner January 30, 2025 18:13
@jcsp jcsp requested a review from skyzh January 30, 2025 18:13
Copy link

github-actions bot commented Jan 30, 2025

7440 tests run: 7088 passed, 0 failed, 352 skipped (full report)


Flaky tests (8)

Postgres 17

Code coverage* (full report)

  • functions: 33.4% (8515 of 25532 functions)
  • lines: 49.1% (71509 of 145554 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7543de9 at 2025-01-31T11:04:23.704Z :recycle:

test_ondemand_download_large_rel pass
@jcsp
Copy link
Collaborator Author

jcsp commented Jan 30, 2025

need to check out test_timeline_archive[debug-pg17-4] flake, since it's related code to this change

@jcsp
Copy link
Collaborator Author

jcsp commented Jan 31, 2025

Confirmed the test_timeline_archive flake matches pre-existing ones

@jcsp jcsp enabled auto-merge January 31, 2025 10:11
@jcsp jcsp added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit f09cfd1 Jan 31, 2025
84 checks passed
@jcsp jcsp deleted the jcsp/archived-freeze-and-flush branch January 31, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants