Only churn rows once in test_scrubber_physical_gc_ancestors #10481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #10457 was supposed to fix the flakiness of
test_scrubber_physical_gc_ancestors
, but instead it made it even more flaky. However, the original error causes disappeared, now to be replaced by key not found errors.See this for a longer explanation: #10391 (comment)
Solution
This does one churn rows after all compactions, and before we do any timeline gc's. That way, we remain more accessible at older lsn's.