Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only churn rows once in test_scrubber_physical_gc_ancestors #10481

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jan 22, 2025

Problem

PR #10457 was supposed to fix the flakiness of test_scrubber_physical_gc_ancestors, but instead it made it even more flaky. However, the original error causes disappeared, now to be replaced by key not found errors.

See this for a longer explanation: #10391 (comment)

Solution

This does one churn rows after all compactions, and before we do any timeline gc's. That way, we remain more accessible at older lsn's.

@arpad-m arpad-m changed the title Only churn rows once Only churn rows once in test_scrubber_physical_gc_ancestors loop Jan 22, 2025
@arpad-m arpad-m changed the title Only churn rows once in test_scrubber_physical_gc_ancestors loop Only churn rows once in test_scrubber_physical_gc_ancestors Jan 22, 2025
@arpad-m arpad-m enabled auto-merge January 22, 2025 19:08
@arpad-m arpad-m added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 0af40b5 Jan 22, 2025
83 checks passed
@arpad-m arpad-m deleted the arpad/churn_rows_separation branch January 22, 2025 19:47
Copy link

7370 tests run: 6984 passed, 0 failed, 386 skipped (full report)


Flaky tests (6)

Postgres 17

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 33.5% (8493 of 25334 functions)
  • lines: 49.3% (71376 of 144677 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4dc9614 at 2025-01-22T19:49:01.608Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants