Do not assign max(lsn) to maxLastWrittenLsn in SetLastWrittenLSNForblokv #10474
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knizhnik
requested review from
MMeent and
lubennikovaav
and removed request for
MMeent
7429 tests run: 7043 passed, 0 failed, 386 skipped (full report)Flaky tests (5)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
c55f571 at 2025-01-24T12:54:43.714Z :recycle: |
MMeent
approved these changes
Jan 24, 2025
knizhnik
force-pushed
the
fix_set_lwlsnv
branch
from
ea41da4 to
c55f571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #10281
SetLastWrittenLSNForBlockvis assigning max(lsn) tomaxLastWrittenLsnwhile its should contain only max LSN not present in LwLSN cache. It case unnecessary waits in PS.Summary of changes
Restore status-quo for pg17.
Related Postgres PR: neondatabase/postgres#563