Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run check-codestyle-rust as part of pre-merge-checks #10387

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

jcgruenhage
Copy link
Member

@jcgruenhage jcgruenhage commented Jan 14, 2025

Problem

When multiple changes are grouped in a merge group to be merged as part of the merge queue, the changes might individually pass check-codestyle-rust but not in their combined form.

Summary of changes

  • Move check-codestyle-rust into a reusable workflow that is called from it's previous location in build_and_test.yml, and additionally call it from pre_merge_checks.yml. The additional call does not run on ARM, only x86, to ensure the merge queue continues being responsive.
  • Trigger pre_merge_checks.yml on PRs that change any of the workflows running in pre_merge_checks.yml, so that we get feedback on those early an not only after trying to merge those changes.

@jcgruenhage jcgruenhage requested a review from a team as a code owner January 14, 2025 14:37
@jcgruenhage jcgruenhage force-pushed the jcgruenhage/rust-codestyle-merge-queue branch from 7d1c7da to 456dd3a Compare January 14, 2025 15:13
Copy link

github-actions bot commented Jan 14, 2025

7304 tests run: 6934 passed, 0 failed, 370 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 32.8% (8154 of 24827 functions)
  • lines: 48.1% (68272 of 142072 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4bbf90d at 2025-01-15T11:26:00.872Z :recycle:

@jcgruenhage jcgruenhage force-pushed the jcgruenhage/rust-codestyle-merge-queue branch from 456dd3a to 4bbf90d Compare January 15, 2025 10:27
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/pre-merge-checks.yml Show resolved Hide resolved
@jcgruenhage jcgruenhage added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 86dbc44 Jan 16, 2025
94 checks passed
@jcgruenhage jcgruenhage deleted the jcgruenhage/rust-codestyle-merge-queue branch January 16, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants