Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: refine how compat snapshot is generated #10342

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 10, 2025

Problem

I noticed in #9537 that tests which work with compat snapshots were writing several hundred MB of data, which isn't really necessary.

Also, the snapshots are large but don't have the proper variety of storage format features, e.g. they could just have L0 deltas.

Summary of changes

  • Use smaller scale factor and runtime to generate less data
  • Configure a small layer size and use force image layer generation so that our output contains L1 deltas and image layers, and has a decent number of entries in the layer map

@jcsp jcsp added the a/tech_debt Area: related to tech debt label Jan 10, 2025
@jcsp jcsp requested a review from bayandin January 10, 2025 12:49
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link

7293 tests run: 6928 passed, 0 failed, 365 skipped (full report)


Flaky tests (1)

Postgres 15

Code coverage* (full report)

  • functions: 32.7% (8044 of 24618 functions)
  • lines: 47.8% (66829 of 139908 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
90b2906 at 2025-01-10T13:45:00.975Z :recycle:

@jcsp jcsp added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 0d4fce2 Jan 10, 2025
89 checks passed
@jcsp jcsp deleted the jcsp/tests-compat-snap-size branch January 10, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants