Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pageserver,safekeeper: disable heap profiling (#10268)" #10303

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

erikgrinaker
Copy link
Contributor

This reverts commit b33299d.

Heap profiles weren't the culprit after all.

Touches #10225.

@erikgrinaker erikgrinaker requested a review from jcsp January 7, 2025 20:24
@erikgrinaker erikgrinaker requested a review from a team as a code owner January 7, 2025 20:24
@erikgrinaker erikgrinaker enabled auto-merge January 7, 2025 20:24
Copy link

github-actions bot commented Jan 7, 2025

7227 tests run: 6873 passed, 0 failed, 354 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Code coverage* (full report)

  • functions: 31.2% (8411 of 26961 functions)
  • lines: 48.0% (66782 of 139225 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
13bef13 at 2025-01-07T21:20:41.452Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 237dae7 Jan 7, 2025
86 checks passed
@erikgrinaker erikgrinaker deleted the erik/enable-heap-profiling branch January 7, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants