Fix promote-images-prod after splitting it out #10292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedordikarev
approved these changes
Jan 7, 2025
bayandin
approved these changes
Jan 7, 2025
bayandin
reviewed
Jan 7, 2025
bayandin
reviewed
Jan 7, 2025
jcgruenhage
force-pushed
the
jcgruenhage/fix-promote-images-prod
branch
from
43a6703 to
5ed9d87
Compare
7227 tests run: 6875 passed, 0 failed, 352 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5ed9d87 at 2025-01-07T13:53:17.619Z :recycle: |
bayandin
pushed a commit
that referenced
this pull request
Jan 7, 2025
## Problem `promote-images` was split into `promote-images-dev` and `promote-images-prod` in #10267. `dev` credentials were loaded in `promote-images-dev` and `prod` credentials were loaded in `promote-images-prod`, but `promote-images-prod` needs `dev` credentials as well to access the `dev` images to replicate them from `dev` to `prod`. ## Summary of changes Load `dev` credentials in `promote-images-prod` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
promote-imageswas split intopromote-images-devandpromote-images-prodin #10267.devcredentials were loaded inpromote-images-devandprodcredentials were loaded inpromote-images-prod, butpromote-images-prodneedsdevcredentials as well to access thedevimages to replicate them fromdevtoprod.Summary of changes
Load
devcredentials inpromote-images-prodas well.