storcon: switch to diesel-async and tokio-postgres #10280
+542
−361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the storcon away from using diesel's synchronous APIs in favour of
diesel-async
.Advantages:
spawn_blocking
We had to turn off usage of the connection pool for migrations, as diesel migrations don't support async APIs. Thus we still use
spawn_blocking
in that one place. But this is explicitly done in one of thediesel-async
examples.