Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accounting of dropped prefetched GetPage requests #10276

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

MMeent
Copy link
Contributor

@MMeent MMeent commented Jan 3, 2025

Apparently, we failed to do this bookkeeping in quite a few places...

Problem

Fixes https://github.com/neondatabase/cloud/issues/22364

Summary of changes

Add accounting of dropped requests. Note that this includes prefetches dropped due to things like "PS connection dropped unexpectedly" or "prefetch queue is already full", but not (yet?) "dropped due to backend shutdown".

Apparently, we failed to do this bookkeeping in quite a few places...
@MMeent MMeent requested review from a team as code owners January 3, 2025 20:18
@MMeent MMeent requested review from myrrc and VladLazar January 3, 2025 20:18
Copy link

github-actions bot commented Jan 3, 2025

7227 tests run: 6875 passed, 0 failed, 352 skipped (full report)


Flaky tests (3)

Postgres 17

  • test_physical_replication_config_mismatch_too_many_known_xids: debug-x86-64

Postgres 16

  • test_physical_replication_config_mismatch_too_many_known_xids: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 31.2% (8411 of 26948 functions)
  • lines: 48.0% (66762 of 139204 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2b51171 at 2025-01-03T21:18:25.876Z :recycle:

@ololobus ololobus requested a review from hlinnaka January 7, 2025 10:11
@MMeent MMeent added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit be38123 Jan 7, 2025
84 checks passed
@MMeent MMeent deleted the MMeent-patch-2 branch January 7, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants