-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic fast_import python test #10271
base: 22100-change-fastimport-db-name
Are you sure you want to change the base?
Basic fast_import python test #10271
Conversation
from fixtures.neon_fixtures import VanillaPostgres, PgProtocol, PgBin | ||
from fixtures.port_distributor import PortDistributor | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps makes sense to make this an extension to test_pgdata_import_smoke
, which has this comment currently:
# We have a Postgres data directory now.
# Make a localfs remote storage that looks like how after `fast_import` ran.
# TODO: actually exercise fast_import here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thought that it might not worth doing it all in the same test due to increased complexity -> more complicated debugging if something is failing. Right now it is using vanilla postgres pgdata as we do in fast import, so it should be enough for testing pageserver part.
Moved mine simple test to the same file, but will keep test_pgdata_import_smoke
the same. Also added a todo to test full import flow separately, which will complement test_pgdata_import_smoke
and test_fast_import_binary
, but not complicate any of those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT?
6460 tests run: 6170 passed, 0 failed, 290 skipped (full report)Flaky tests (2)Postgres 17
Postgres 16
Test coverage report is not availableThe comment gets automatically updated with the latest test results
e856fae at 2025-01-06T20:50:28.045Z :recycle: |
1b08f3c
to
122e324
Compare
122e324
to
e856fae
Compare
We did not have any tests on fast_import binary yet.
In this PR I have introduced:
FastImport
class and tools for testing in pythonShould be merged after #10251