Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): dont trigger error alerts for unknown topics #10266

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

conradludgate
Copy link
Contributor

Problem

Before the holidays, and just before our code freeze, a change to cplane was made that started publishing the topics from #10197. This triggered our alerts and put us in a sticky situation as it was not an error, and we didn't want to silence the alert for the entire holidays, and we didn't want to release proxy 2 days in a row if it was not essential.

We fixed it eventually by rewriting the alert based on logs, but this is not a good solution.

Summary of changes

Introduces an intermediate parsing step to check the topic name first, to allow us to ignore parsing errors for any topics we do not know about.

@conradludgate conradludgate requested a review from a team as a code owner January 3, 2025 13:50
proxy/src/redis/notifications.rs Show resolved Hide resolved
Copy link

github-actions bot commented Jan 3, 2025

7227 tests run: 6875 passed, 0 failed, 352 skipped (full report)


Flaky tests (2)

Postgres 15

Postgres 14

  • test_physical_replication_config_mismatch_too_many_known_xids: release-arm64

Code coverage* (full report)

  • functions: 31.2% (8409 of 26961 functions)
  • lines: 48.0% (66776 of 139215 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fddd23b at 2025-01-06T13:06:08.981Z :recycle:

@conradludgate conradludgate added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit fda52a0 Jan 6, 2025
82 checks passed
@conradludgate conradludgate deleted the conrad/proxy-ignore-unknown-messages branch January 6, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants