-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(proxy): remove postgres notice logs #10254
base: main
Are you sure you want to change the base?
Conversation
An alternative worth considering is to instead include these notices in the HTTP response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative worth considering is to instead include these notices in the HTTP response.
You mean as http2/websocket side-channel or embedding them in the response JSON?
In the response JSON, where along side the |
Websocket connections are not managed by us, and they would get all the notices by default |
7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1d644b8 at 2025-01-02T17:29:28.625Z :recycle: |
…ostgres connection
…ue, as it can only store 1 item
e288da7
to
1d644b8
Compare
The notice logs don't serve much utility for us for managed connections, so we can remove them.
As a side effect, the notice infrastructure within connection.rs is no longer necessary which allows us to simplify some things.