Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): remove postgres notice logs #10254

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

conradludgate
Copy link
Contributor

The notice logs don't serve much utility for us for managed connections, so we can remove them.

As a side effect, the notice infrastructure within connection.rs is no longer necessary which allows us to simplify some things.

@conradludgate conradludgate requested a review from a team as a code owner January 2, 2025 11:13
@conradludgate
Copy link
Contributor Author

An alternative worth considering is to instead include these notices in the HTTP response.

Copy link
Contributor

@cloneable cloneable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative worth considering is to instead include these notices in the HTTP response.

You mean as http2/websocket side-channel or embedding them in the response JSON?

@conradludgate
Copy link
Contributor Author

In the response JSON, where along side the results: [ ... ] there could be a notices: [ ... ]. I don't know if it's worth the effort though. No one has asked for it either.

@conradludgate
Copy link
Contributor Author

Websocket connections are not managed by us, and they would get all the notices by default

Copy link

github-actions bot commented Jan 2, 2025

7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.2% (8400 of 26933 functions)
  • lines: 47.9% (66678 of 139070 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1d644b8 at 2025-01-02T17:29:28.625Z :recycle:

@conradludgate conradludgate force-pushed the conrad/proxy-remove-notice-logs branch from e288da7 to 1d644b8 Compare January 2, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants