safekeeper: add membership configuration switch endpoint #10241
+198
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arssher
force-pushed
the
sk-membership-switch-ep
branch
from
060a731 to
0f2c8d9
Compare
7106 tests run: 6768 passed, 34 failed, 304 skipped (full report)Failures on Postgres 17
Failures on Postgres 16
Failures on Postgres 15
Failures on Postgres 14
Flaky tests (2)Postgres 15
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
0f2c8d9 at 2024-12-25T14:26:11.971Z :recycle: |
Also add it to python client for tests, and add simple test itself.
arssher
force-pushed
the
sk-membership-switch-ep
branch
from
0f2c8d9 to
0f097d5
Compare
arssher
force-pushed
the
sk-membership-cf
branch
from
db87b9e to
f552684
Compare
arpad-m
approved these changes
Jan 3, 2025
| log.info(f"conf after restart: {after_restart}") | ||
| assert after_restart.generation == 4 | ||
|
|
||
| # Switch into non join conf. |
There was a problem hiding this comment.
Suggested change
| # Switch into non join conf. | |
| # Switch into disjoint conf. |
| @@ -170,7 +193,10 @@ def timeline_status( | |||
| res.raise_for_status() | |||
| resj = res.json() | |||
| walreceivers = [Walreceiver(wr["conn_id"], wr["status"]) for wr in resj["walreceivers"]] | |||
| # It is always normally not None, it is allowed only to make forward compat tests happy. | |||
| mconf = Configuration.from_json(resj["mconf"]) if "mconf" in resj else None | |||
There was a problem hiding this comment.
This still causes KeyError: 'mconf' to be issued if not present, causing some test failures (see test bot comment above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#9965
Summary of changes
Add to safekeeper http endpoint to switch membership configuration. Also add it to python client for tests, and add simple test itself.