Refactor MigrationRunner::run_migrations() to call a helper #10232
+43
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
requested review from
lubennikovaav
and removed request for
a team
7227 tests run: 6874 passed, 0 failed, 353 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f6daa2e at 2025-01-06T21:00:16.477Z :recycle: |
tristan957
force-pushed
the
tristan957/refactor
branch
from
780f4e6 to
0ce45be
Compare
tristan957
force-pushed
the
tristan957/inline-queries
branch
from
5d2e111 to
1fe1430
Compare
tristan957
force-pushed
the
tristan957/refactor
branch
from
0ce45be to
042e5ae
Compare
ololobus
reviewed
Jan 6, 2025
tristan957
force-pushed
the
tristan957/refactor
branch
from
042e5ae to
c25f765
Compare
|
I also recently learned that the |
tristan957
force-pushed
the
tristan957/refactor
branch
from
c25f765 to
6d0c0a5
Compare
ololobus
approved these changes
Jan 6, 2025
Cool. Thanks for the reviews! |
tristan957
force-pushed
the
tristan957/refactor
branch
from
6d0c0a5 to
82510c5
Compare
This will make it easier to add cluster migrations, such as that for CVE-2024-4317. Link: https://www.postgresql.org/support/security/CVE-2024-4317/ Signed-off-by: Tristan Partin <[email protected]>
tristan957
force-pushed
the
tristan957/refactor
branch
from
82510c5 to
f6daa2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add per-db migrations, such as that for
CVE-2024-4317.
Link: https://www.postgresql.org/support/security/CVE-2024-4317/
Signed-off-by: Tristan Partin [email protected]