azure_blob: connect/read timeouts to the reqwest client #10147
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We already have timeouts at the higher levels of the stack, via select and friends, but the timeouts might not actually reach the reqwest client. That might lead to port exhaustion issus later on as the higher level timeouts don't clean up the ports. Therefore, set it up in a way that the timeouts are preconfigured.
https://github.com/neondatabase/cloud/issues/20971
Summary of changes
Pass down timeouts from the SDK to the reqwest client. Hopefully this will address the port exhaustion issue. We always use
read_timeout
because that one is shorter: there is only one global timeout we can configure.Related earlier work: #9938