Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter): password not set in role drop #10130

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

myrrc
Copy link
Contributor

@myrrc myrrc commented Dec 12, 2024

Problem

When entry was dropped and password wasn't set, new entry
had uninitialized memory in controlplane adapter

Resolves: https://github.com/neondatabase/cloud/issues/14914

Summary of changes

Initialize password in all cases, add tests.
Minor formatting for less indentation

@myrrc myrrc requested review from a team as code owners December 12, 2024 20:55
@myrrc myrrc requested review from knizhnik and VladLazar December 12, 2024 20:55
@myrrc myrrc force-pushed the 14914-adapter-savepoints-segfault branch from 3759b6b to 3d7775b Compare December 12, 2024 20:57
Copy link

github-actions bot commented Dec 12, 2024

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

  • test_pgdata_import_smoke[8-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Postgres 15

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
  • test_pgdata_import_smoke[8-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
  • test_parallel_copy: release-arm64
  • test_physical_replication_config_mismatch_too_many_known_xids: release-arm64

Postgres 14

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Code coverage* (full report)

  • functions: 31.4% (8401 of 26778 functions)
  • lines: 48.1% (66630 of 138651 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d1c5eb0 at 2024-12-13T22:28:05.605Z :recycle:

test_runner/regress/test_ddl_forwarding.py Outdated Show resolved Hide resolved
pgxn/neon/control_plane_connector.c Outdated Show resolved Hide resolved
pgxn/neon/control_plane_connector.c Show resolved Hide resolved
@myrrc myrrc requested review from tristan957 and knizhnik December 13, 2024 21:09
@myrrc
Copy link
Contributor Author

myrrc commented Dec 13, 2024

Regarding failures of test_pageserver_small_inmemory_layers, I fail to reproduce the error, though I notice the test may run for 1:50 or so

@myrrc myrrc enabled auto-merge December 14, 2024 17:36
@myrrc myrrc added this pull request to the merge queue Dec 14, 2024
Merged via the queue into main with commit cf161e1 Dec 14, 2024
82 checks passed
@myrrc myrrc deleted the 14914-adapter-savepoints-segfault branch December 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants