Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly update LFC used_pages in case of LFC resize #10128

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Correctly update LFC used_pages in case of LFC resize #10128

merged 1 commit into from
Dec 13, 2024

Conversation

knizhnik
Copy link
Contributor

Problem

LFC used_pages statistic is not updated in case of LFC resize (shrinking neon.file_cache_size_limit)

Summary of changes

Update lfc_ctl->used_pages in lfc_change_limit_hook

@knizhnik knizhnik requested review from a team as code owners December 12, 2024 20:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

7766 tests run: 7435 passed, 0 failed, 331 skipped (full report)

Flaky tests (4)

Postgres 17

Postgres 15

Postgres 14

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Code coverage* (full report)

  • functions: 31.4% (8402 of 26732 functions)
  • lines: 48.1% (66642 of 138650 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
f1f90f4 at 2024-12-13T07:37:07.110Z :recycle:

myrrc
myrrc approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@myrrc myrrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knizhnik knizhnik added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit eeabecd Dec 13, 2024
86 checks passed
@knizhnik knizhnik deleted the fix_lfc_used_pages branch December 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myrrc myrrc myrrc approved these changes

@lubennikovaav lubennikovaav Awaiting requested review from lubennikovaav lubennikovaav is a code owner automatically assigned from neondatabase/compute

@problame problame Awaiting requested review from problame problame is a code owner automatically assigned from neondatabase/storage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knizhnik @myrrc