Skip to content

Commit

Permalink
remote_storage: enable Azure connection pooling by default
Browse files Browse the repository at this point in the history
  • Loading branch information
jcsp committed Jan 9, 2025
1 parent 5baa4e7 commit 3358647
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions libs/remote_storage/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,15 @@ fn default_max_keys_per_list_response() -> Option<i32> {
}

fn default_azure_conn_pool_size() -> usize {
// Conservative default: no connection pooling. At time of writing this is the Azure
// SDK's default as well, due to historic reports of hard-to-reproduce issues
// By default, the Azure SDK does no connection pooling, due to historic reports of hard-to-reproduce issues
// (https://github.com/hyperium/hyper/issues/2312)
//
// However, using connection pooling is important to avoid exhausting client ports when
// doing huge numbers of requests (https://github.com/neondatabase/cloud/issues/20971)
0
//
// We therefore enable a modest pool size by default: this may be configured to zero if
// issues like the alleged upstream hyper issue appear.
8
}

impl Debug for S3Config {
Expand Down

0 comments on commit 3358647

Please sign in to comment.