Skip to content

Commit

Permalink
fix(compute): Report compute_backpressure_throttling_seconds as counter
Browse files Browse the repository at this point in the history
It was reported as `gauge`, but it's actually a `counter`.

Also add `_total` suffix as that's the convention for counters.
  • Loading branch information
ololobus committed Dec 17, 2024
1 parent b5833ef commit 12756e1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion compute/etc/neon_collector.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
metrics: [
import 'sql_exporter/checkpoints_req.libsonnet',
import 'sql_exporter/checkpoints_timed.libsonnet',
import 'sql_exporter/compute_backpressure_throttling_seconds.libsonnet',
import 'sql_exporter/compute_backpressure_throttling_seconds_total.libsonnet',
import 'sql_exporter/compute_current_lsn.libsonnet',
import 'sql_exporter/compute_logical_snapshot_files.libsonnet',
import 'sql_exporter/compute_logical_snapshots_bytes.libsonnet',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
metric_name: 'compute_backpressure_throttling_seconds',
type: 'gauge',
metric_name: 'compute_backpressure_throttling_seconds_total',
type: 'counter',
help: 'Time compute has spent throttled',
key_labels: null,
values: [
'throttled',
],
query: importstr 'sql_exporter/compute_backpressure_throttling_seconds.sql',
query: importstr 'sql_exporter/compute_backpressure_throttling_seconds_total.sql',
}

0 comments on commit 12756e1

Please sign in to comment.