TextToSpeech to utilize passed device arg #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonbjb
requested changes
Jan 26, 2023
tortoise/api.py
Outdated
| @@ -213,7 +213,9 @@ def __init__(self, autoregressive_batch_size=None, models_dir=MODELS_DIR, enable | |||
| self.models_dir = models_dir | |||
| self.autoregressive_batch_size = pick_best_batch_size_for_gpu() if autoregressive_batch_size is None else autoregressive_batch_size | |||
| self.enable_redaction = enable_redaction | |||
| self.device = torch.device('cuda' if torch.cuda.is_available() else 'cpu') | |||
| if device is None: | |||
| device = torch.device('cuda' if torch.cuda.is_available() else 'cpu') | |||
There was a problem hiding this comment.
Hey thanks for the PR and sorry for the late review. Given how poorly this program performs on CPU, can you please print out a warning here?
There was a problem hiding this comment.
Hey, late review? Guess you didn't expect an update from me.
What do you think about the change?
p0p4k
added a commit
to p0p4k/tortoise-tts
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started playing with the code and noticed that
deviceisn't used intortois.api.TextToSpeech.Please let me know if that was intentional and there are some things to look for.