Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Librex engine only returns one result on the search page #619

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

jf-botto
Copy link
Contributor

@jf-botto jf-botto commented Oct 8, 2024

What does this PR do?

Resolves the librex returning only 1 search result. By making it return more than 1 result by fixing the results selector.

Why is this change important?

Enchances the user experience.

How to test this PR locally?

Enabling only Librex and trying a search with the fixed results selector returns more than 1 result.

Related issues

Fixes #482

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Websurfx! ❤️!
Say hello by joining the conversation in our Discord

@jf-botto jf-botto marked this pull request as ready for review October 9, 2024 09:23
@neon-mmd neon-mmd changed the title 482 - Fixing Librex SearchResultParser results selector 🐛 Librex engine only returns one result on the search page Oct 9, 2024
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ for working on such a wonderful PR. We really appreciate it. Good job!! Keep it up!! 👍 . Since everything looks good. We will merge this PR as soon as possible 🙂 .

@mergify mergify bot merged commit ef0ae2f into neon-mmd:rolling Nov 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐛 Librex engine only returns one result on the search page
3 participants