✨ Implement qwant search engine support
#605
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Websurfx! ❤️!
Say hello by joining the conversation in our Discord
This makes sure that if a user uses & or any other symbol with special meaning their query won't get broken
neon-mmd
changed the title
qwant search engine support
neon-mmd
requested changes
Sep 7, 2024
Comment on lines
+144
to
+152
| let result: QwantApiResponse = client | ||
| .get(url) | ||
| .headers(header_map) | ||
| .send() | ||
| .await | ||
| .change_context(EngineError::RequestError)? | ||
| .json() | ||
| .await | ||
| .change_context(EngineError::RequestError)?; |
There was a problem hiding this comment.
I think you could have used the already available json_as_bytes_from_upstream function to fetch data and deserialize it using something like bincode. What do you think? 🙂 .
|
@nrabulinski It has been a week. Any updates on this draft PR? 🙂 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the Qwant search engine support
Why is this change important?
I wanted to contribute the Qwant search engine support
How to test this PR locally?
Run websurfx and enable the Qwant search engine
Additional notes
Sometimes, requesting results from Qwant fails. So far I've encountered error 22 which I don't know what it means, and error 27 which means completing a captcha is required. Second request pretty much always works for me though. Not sure if that's an acceptable state, if not, I'm happy to potentially help with captcha implementation.
This search engine is implemented using the API, contrary to other ones which use scripting. That's because Qwant's frontend is not paginated and there's no way to force it to be, so I couldn't scrape more than one page worth of results. And because of that I decided to just use the API itself.
Related issues
Closes #317