Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Config option to configure the number of connections to have in the reqwest pool #552

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

KekmaTime
Copy link
Contributor

@KekmaTime KekmaTime commented Mar 31, 2024

What does this PR do?

Provided a new config option to modify the number of https connections in the reqwest connections pool.

Why is this change important?

The reason behind including these changes is to allow the user to configure the amount of connections to have in the reqwest connection pool which can help keep user specified amount of connections in the pool which can help reduce the time it takes to create new connections by using the existing available connections in the pool which in turn helps improve user experience.

Related issues

Closes #532

@alamin655 alamin655 changed the title ✨ Config option to configure the number of connections to have in the reqwest pool ✨ Config option to configure the number of connections to have in the reqwest pool Apr 2, 2024
@alamin655 alamin655 requested a review from neon-mmd April 2, 2024 13:52
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
Thanks ❤️ for working on this PR. We really appreciate it 👍 Keep it up!! But before we merge this PR. we would like to suggest a few changes. 🙂

websurfx/config.lua Show resolved Hide resolved
neon-mmd

This comment was marked as resolved.

Copy link

github-actions bot commented Sep 3, 2024

Stale pull request message

@neon-mmd
Copy link
Owner

neon-mmd commented Sep 3, 2024

@KekmaTime Any updates on this PR so far? Would love to hear 🙂 .

@KekmaTime
Copy link
Contributor Author

@KekmaTime Any updates on this PR so far? Would love to hear 🙂 .

im sorry @neon-mmd i havent checked it into this issue. Ill check it right away

@KekmaTime
Copy link
Contributor Author

@neon-mmd ive made a few changes please review as per your time.

Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ again for working on such a cool PR. Good job!! Keep it up!! 👍 Since everything looks good. We will merge this PR right away 🚀 🙂

@neon-mmd neon-mmd merged commit 2a4dd07 into neon-mmd:rolling Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

✨ Config option to configure the number of connections to have in the reqwest pool
3 participants