-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Config option to configure the number of connections to have in the reqwest
pool
#552
Conversation
reqwest
pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply.
Thanks ❤️ for working on this PR. We really appreciate it 👍 Keep it up!! But before we merge this PR. we would like to suggest a few changes. 🙂
Stale pull request message |
@KekmaTime Any updates on this PR so far? Would love to hear 🙂 . |
im sorry @neon-mmd i havent checked it into this issue. Ill check it right away |
@neon-mmd ive made a few changes please review as per your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️ again for working on such a cool PR. Good job!! Keep it up!! 👍 Since everything looks good. We will merge this PR right away 🚀 🙂
What does this PR do?
Provided a new config option to modify the number of
https
connections in the reqwest connections pool.Why is this change important?
The reason behind including these changes is to allow the user to configure the amount of connections to have in the
reqwest
connection pool which can help keep user specified amount of connections in the pool which can help reduce the time it takes to create new connections by using the existing available connections in the pool which in turn helps improve user experience.Related issues
Closes #532