[Fix]: Make runs entirely lazily, adding back support for handling VersionCatalogues #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it might not be possible to detect those at all times.
Last commit published: dfa0ec8c9f9b8f9847f0ad8c7c35766571582420. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #230' // https://github.com/neoforged/NeoGradle/pull/230
url 'https://prmaven.neoforged.net/NeoGradle/pr230'
content {
includeModule('net.neoforged.gradle', 'common')
includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-common')
includeModule('net.neoforged.gradle', 'dsl-vanilla')
includeModule('net.neoforged.gradle', 'dsl-mixin')
includeModule('net.neoforged.gradle', 'dsl-platform')
includeModule('net.neoforged.gradle', 'dsl-userdev')
includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
includeModule('net.neoforged.gradle', 'neoform')
includeModule('net.neoforged.gradle', 'mixin')
includeModule('net.neoforged.gradle', 'test-utils')
includeModule('net.neoforged.gradle', 'userdev')
includeModule('net.neoforged.gradle', 'vanilla')
includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
includeModule('net.neoforged.gradle', 'utils')
includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
includeModule('net.neoforged.gradle', 'platform')
includeModule('net.neoforged.gradle', 'dsl-neoform')
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the final and full fix for the
whenObjectAddedreplacement, lazy dependencies are not fully realised in time for replacement and run creation.So runs invoked where not realised and it was not possible to configure them with data from their SDK types.
This PR changes this by making runs fully lazy, loading their data from the CP if needbe and configuring them completely internally.
I wished that that I could make it fully lazy but that requires some further modifications to the internal spec, and this suffices for now.
When using a version library you will need to create the runs manually, as gradle actually realises the dependency way to late for us to register a run.