Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add support for DevLogin #192

Merged
merged 14 commits into from
Jun 4, 2024
Merged

[Feature]: Add support for DevLogin #192

merged 14 commits into from
Jun 4, 2024

Conversation

marchermans
Copy link
Contributor

@marchermans marchermans commented May 29, 2024

TLDR:

  • This adds supports for DevLogin on client runs

DevLogin Support:

We now support the use of DevLogin by @covers1624.
You can use the following DSL to enable it:

runs {
    someRun {
        devLogin {
           enabled true
        }
    }
}

By default the tool is disabled on all client runs.

Warning

If you enable the dev login tool for a none client run, you will get an error message.

Better error handling:

There is now better error handling if you do not configure mod sources in a run.

Closes:

Closes: #100

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 29, 2024

  • Publish PR to GitHub Packages

Last commit published: 963b58710c7c9770ba0be3fbf769d59881e28ea6.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #192' // https://github.com/neoforged/NeoGradle/pull/192
        url 'https://prmaven.neoforged.net/NeoGradle/pr192'
        content {
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle', 'test-utils')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
        }
    }
}

@marchermans marchermans enabled auto-merge (squash) May 29, 2024 11:50
Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it disabled by default. At least in neodev.

@Technici4n Technici4n disabled auto-merge May 29, 2024 11:51
@marchermans
Copy link
Contributor Author

Please make it disabled by default. At least in neodev.

Is there a reason why?
Not against this, just want to know why, so I can leave a comment explaining the need to disable it in dynprojects.

@marchermans
Copy link
Contributor Author

Please make it disabled by default. At least in neodev.

Is there a reason why? Not against this, just want to know why, so I can leave a comment explaining the need to disable it in dynprojects.

Clarified via discord. Was personal preference of @Technici4n.

We decided to disable the flag on the run, this leaves the subsystem enabled, while having no effect for the user.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@marchermans
Copy link
Contributor Author

Addressed all comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@covers1624
Copy link
Member

Glad to see a tool I wrote to give me my skin in-dev put to real use.

It may be worth exposing DevLogin's profile system via the DSL --launch_profile, so modders can easily use their alts. Just a simple identifier string for the profile.

@marchermans marchermans merged commit 602139f into NG_7.0 Jun 4, 2024
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add DevLogin support to client run configs
5 participants