Create a ConfigureMainRenderTargetEvent for enabling stenciling, simplified(?) #1830
+307
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nTarget configuration event
Other patches are still necessary as other targets have that as a valid combination in vanilla anyway, and post chains can be configured to render to a target with depth disabled.
Last commit published: f62e41755b774e1496d70585d35307fb7ae567dd. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1830' // https://github.com/neoforged/NeoForge/pull/1830
url 'https://prmaven.neoforged.net/NeoForge/pr1830'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1830
cd NeoForge-pr1830
curl -L https://prmaven.neoforged.net/NeoForge/pr1830/net/neoforged/neoforge/21.4.68-beta-pr-1830-feature-depth-stenciling/mdk-pr1830.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
Technici4n
commented
Jan 9, 2025
| this.window.setGuiScale((double)i); | ||
| if (this.screen != null) { | ||
| this.screen.resize(this, this.window.getGuiScaledWidth(), this.window.getGuiScaledHeight()); | ||
| + net.neoforged.neoforge.client.ClientHooks.resizeGuiLayers(this, this.window.getGuiScaledWidth(), this.window.getGuiScaledHeight()); | ||
| } | ||
|
|
||
| RenderTarget rendertarget = this.getMainRenderTarget(); | ||
| + if (rendertarget != null) |
Technici4n
commented
Jan 9, 2025
| Matrix4f matrix4f = new Matrix4f().setOrtho(0.0F, (float)p_361423_, 0.0F, (float)p_362735_, 0.1F, 1000.0F); | ||
| Map<ResourceLocation, ResourceHandle<RenderTarget>> map = new HashMap<>(this.internalTargets.size() + this.externalTargets.size()); | ||
|
|
||
| + // Enable the depth and stencil buffers based on whether any external targets use them. |
There was a problem hiding this comment.
Not sure what this patch is trying to achieve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1715, but without the ability to instantiate render targets that have stencil enabled but not depth. Also brought further simplifications from FiniteReality#1.