Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Sync remaining c tags from Fabric side #1628

Merged
merged 32 commits into from
Dec 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
22d2cfb
Sync with fabric tags
TelepathicGrunt Oct 13, 2024
3b2ebd2
Add torchflower seeds tag
TelepathicGrunt Oct 13, 2024
671174c
Improved the javadoc for ore rates
TelepathicGrunt Oct 13, 2024
6288029
add mushrooms javadoc
TelepathicGrunt Oct 13, 2024
828782a
added seeds javadoc
TelepathicGrunt Oct 13, 2024
3593e39
addsparse and dense vegetation javadoc
TelepathicGrunt Oct 13, 2024
7f08d7a
Added lush javadoc
TelepathicGrunt Oct 13, 2024
a3d60a1
Added magical javadoc
TelepathicGrunt Oct 13, 2024
3d0a53a
Added rare javadoc
TelepathicGrunt Oct 13, 2024
72e677f
plateau javadoc
TelepathicGrunt Oct 13, 2024
1be0da6
Deprecate is modified tag for removal in future
TelepathicGrunt Oct 13, 2024
8182d6e
Added spooky javadoc
TelepathicGrunt Oct 13, 2024
a2e06c7
more javadoc and fixed biomes in temperature tag
TelepathicGrunt Oct 14, 2024
cbb4cbb
fixed typo in biome temperature tag javadoc
TelepathicGrunt Oct 14, 2024
1b63348
attempt 2 at potion tag javadoc
TelepathicGrunt Oct 14, 2024
2b7215c
Add bottled potion subtag
TelepathicGrunt Oct 14, 2024
bfeefc5
Datagen biome temperature fix
TelepathicGrunt Oct 14, 2024
c2c0507
Improved potion javadoc more
TelepathicGrunt Oct 14, 2024
87bccd6
Changed potion verb to noun
TelepathicGrunt Oct 14, 2024
2d3ec4b
Improve potion javadoc to mention data component
TelepathicGrunt Oct 14, 2024
c666f78
Merge branch '1.21.x' into SyncToFabricTags2
TelepathicGrunt Dec 12, 2024
0892660
Added 1.21.4 tags from fabric
TelepathicGrunt Dec 13, 2024
e108804
Added missing pale wood stuff in tags
TelepathicGrunt Dec 13, 2024
6553f2c
Merge branch '1.21.x' into SyncToFabricTags2
TelepathicGrunt Dec 13, 2024
df6f7fd
adjust resin tag name
TelepathicGrunt Dec 13, 2024
603e405
Bottled Potions
TelepathicGrunt Dec 13, 2024
03094bb
Bottled Potions datagen
TelepathicGrunt Dec 13, 2024
1bc3f63
Update src/main/java/net/neoforged/neoforge/common/Tags.java
TelepathicGrunt Dec 15, 2024
31cae73
fix build and address nether brick fence lang
TelepathicGrunt Dec 15, 2024
f582e8b
singular plateau translation
TelepathicGrunt Dec 15, 2024
3fea4f1
improve javadoc to be clear on tag name for ore bearing and or in tags
TelepathicGrunt Dec 15, 2024
62cde00
Merge branch '1.21.x' into SyncToFabricTags2
TelepathicGrunt Dec 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add torchflower seeds tag
TelepathicGrunt committed Oct 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 3b2ebd2e7244f1fba8d3446f40441bb8ce6b3f9d
1 change: 1 addition & 0 deletions src/generated/resources/assets/c/lang/en_us.json
Original file line number Diff line number Diff line change
@@ -328,6 +328,7 @@
"tag.item.c.seeds.beetroot": "Beetroot Seeds",
"tag.item.c.seeds.melon": "Melon Seeds",
"tag.item.c.seeds.pumpkin": "Pumpkin Seeds",
"tag.item.c.seeds.torchflower": "Torchflower Seeds",
"tag.item.c.seeds.wheat": "Wheat Seeds",
"tag.item.c.shulker_boxes": "Shulker Boxes",
"tag.item.c.slime_balls": "Slimeballs",
1 change: 1 addition & 0 deletions src/generated/resources/data/c/tags/item/seeds.json
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"#c:seeds/beetroot",
"#c:seeds/melon",
"#c:seeds/pumpkin",
"#c:seeds/torchflower",
"#c:seeds/wheat",
{
"id": "#forge:seeds",
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"values": [
"minecraft:torchflower_seeds"
]
}
1 change: 1 addition & 0 deletions src/main/java/net/neoforged/neoforge/common/Tags.java
Original file line number Diff line number Diff line change
@@ -591,6 +591,7 @@ public static class Items {
public static final TagKey<Item> SEEDS_BEETROOT = tag("seeds/beetroot");
public static final TagKey<Item> SEEDS_MELON = tag("seeds/melon");
public static final TagKey<Item> SEEDS_PUMPKIN = tag("seeds/pumpkin");
public static final TagKey<Item> SEEDS_TORCHFLOWER = tag("seeds/torchflower");
public static final TagKey<Item> SEEDS_WHEAT = tag("seeds/wheat");
/**
* Block tag equivalent is {@link BlockTags#SHULKER_BOXES}
Original file line number Diff line number Diff line change
@@ -218,10 +218,11 @@ public void addTags(HolderLookup.Provider lookupProvider) {
copy(Tags.Blocks.SANDSTONE_UNCOLORED_BLOCKS, Tags.Items.SANDSTONE_UNCOLORED_BLOCKS);
copy(Tags.Blocks.SANDSTONE_UNCOLORED_SLABS, Tags.Items.SANDSTONE_UNCOLORED_SLABS);
copy(Tags.Blocks.SANDSTONE_UNCOLORED_STAIRS, Tags.Items.SANDSTONE_UNCOLORED_STAIRS);
tag(Tags.Items.SEEDS).addTags(Tags.Items.SEEDS_BEETROOT, Tags.Items.SEEDS_MELON, Tags.Items.SEEDS_PUMPKIN, Tags.Items.SEEDS_WHEAT);
tag(Tags.Items.SEEDS).addTags(Tags.Items.SEEDS_BEETROOT, Tags.Items.SEEDS_MELON, Tags.Items.SEEDS_PUMPKIN, Tags.Items.SEEDS_TORCHFLOWER, Tags.Items.SEEDS_WHEAT);
tag(Tags.Items.SEEDS_BEETROOT).add(Items.BEETROOT_SEEDS);
tag(Tags.Items.SEEDS_MELON).add(Items.MELON_SEEDS);
tag(Tags.Items.SEEDS_PUMPKIN).add(Items.PUMPKIN_SEEDS);
tag(Tags.Items.SEEDS_TORCHFLOWER).add(Items.TORCHFLOWER_SEEDS);
tag(Tags.Items.SEEDS_WHEAT).add(Items.WHEAT_SEEDS);
tag(Tags.Items.SLIMEBALLS).add(Items.SLIME_BALL); // Deprecated
tag(Tags.Items.SLIME_BALLS).add(Items.SLIME_BALL).addOptionalTag(Tags.Items.SLIMEBALLS);
Original file line number Diff line number Diff line change
@@ -302,6 +302,7 @@ protected void addTranslations() {
add(Tags.Items.SEEDS_BEETROOT, "Beetroot Seeds");
add(Tags.Items.SEEDS_MELON, "Melon Seeds");
add(Tags.Items.SEEDS_PUMPKIN, "Pumpkin Seeds");
add(Tags.Items.SEEDS_TORCHFLOWER, "Torchflower Seeds");
add(Tags.Items.SEEDS_WHEAT, "Wheat Seeds");
add(Tags.Items.SHULKER_BOXES, "Shulker Boxes");
add(Tags.Items.SLIME_BALLS, "Slimeballs");