Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1] Sync remaining c tags from Fabric side #1593

Merged
merged 24 commits into from
Feb 20, 2025
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c82a610
Sync with fabric tags
TelepathicGrunt Oct 13, 2024
fd5e0e5
Add torchflower seeds tag
TelepathicGrunt Oct 13, 2024
923b4ad
Improved the javadoc for ore rates
TelepathicGrunt Oct 13, 2024
8ec15e6
add mushrooms javadoc
TelepathicGrunt Oct 13, 2024
5a4b50d
added seeds javadoc
TelepathicGrunt Oct 13, 2024
a9b6d5f
addsparse and dense vegetation javadoc
TelepathicGrunt Oct 13, 2024
961d784
Added lush javadoc
TelepathicGrunt Oct 13, 2024
dff2525
Added magical javadoc
TelepathicGrunt Oct 13, 2024
2780a61
Added rare javadoc
TelepathicGrunt Oct 13, 2024
d53dea1
plateau javadoc
TelepathicGrunt Oct 13, 2024
99b4fc4
Deprecate is modified tag for removal in future
TelepathicGrunt Oct 13, 2024
1b6d340
Added spooky javadoc
TelepathicGrunt Oct 13, 2024
91578f6
more javadoc and fixed biomes in temperature tag
TelepathicGrunt Oct 14, 2024
6c35625
fixed typo in biome temperature tag javadoc
TelepathicGrunt Oct 14, 2024
8220af1
attempt 2 at potion tag javadoc
TelepathicGrunt Oct 14, 2024
c8a6391
Add bottled potion subtag
TelepathicGrunt Oct 14, 2024
c7bd387
Datagen biome temperature fix
TelepathicGrunt Oct 14, 2024
014e046
Improved potion javadoc more
TelepathicGrunt Oct 14, 2024
2a2e44f
Changed potion verb to noun
TelepathicGrunt Oct 14, 2024
6525396
Improve potion javadoc to mention data component
TelepathicGrunt Oct 14, 2024
f0c8e3d
Merge branch '1.21.x' into SyncToFabricTags
TelepathicGrunt Oct 15, 2024
5a6a281
backport adjustments and egg PR
TelepathicGrunt Feb 16, 2025
2ee7711
Merge branch '1.21.1' into SyncToFabricTags
TelepathicGrunt Feb 16, 2025
d241cfe
Merge branch '1.21.1' into SyncToFabricTags
TelepathicGrunt Feb 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Sync with fabric tags
TelepathicGrunt committed Oct 13, 2024
commit c82a610c34a90c8d827d0f9a89e71356f831f73e
5 changes: 5 additions & 0 deletions src/generated/resources/assets/c/lang/en_us.json
Original file line number Diff line number Diff line change
@@ -299,6 +299,7 @@
"tag.item.c.ores_in_ground.stone": "Stone Ores In Ground",
"tag.item.c.player_workstations.crafting_tables": "Crafting Tables",
"tag.item.c.player_workstations.furnaces": "Furnaces",
"tag.item.c.potions": "Potions",
"tag.item.c.raw_materials": "Raw Materials",
"tag.item.c.raw_materials.copper": "Copper Raw Materials",
"tag.item.c.raw_materials.gold": "Gold Raw Materials",
@@ -425,6 +426,10 @@
"tag.worldgen.biome.c.is_stony_shores": "Stony Shores",
"tag.worldgen.biome.c.is_swamp": "Swamps",
"tag.worldgen.biome.c.is_taiga": "Taiga",
"tag.worldgen.biome.c.is_temperate": "Temperate",
"tag.worldgen.biome.c.is_temperate.end": "Temperate End",
"tag.worldgen.biome.c.is_temperate.nether": "Temperate Nether",
"tag.worldgen.biome.c.is_temperate.overworld": "Temperate Overworld",
"tag.worldgen.biome.c.is_tree.coniferous": "Coniferous Trees",
"tag.worldgen.biome.c.is_tree.deciduous": "Deciduous Trees",
"tag.worldgen.biome.c.is_tree.jungle": "Jungle Trees",
7 changes: 7 additions & 0 deletions src/generated/resources/data/c/tags/item/potions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"values": [
"minecraft:potion",
"minecraft:splash_potion",
"minecraft:lingering_potion"
]
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"values": [
"#c:is_cold/overworld",
{
"id": "#c:is_cold/nether",
"required": false
},
"#c:is_cold/nether",
"#c:is_cold/end",
{
"id": "#forge:is_cold",
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
{
"values": [
"#c:is_dense_vegetation/overworld",
{
"id": "#c:is_dense_vegetation/nether",
"required": false
},
{
"id": "#c:is_dense_vegetation/end",
"required": false
},
"#c:is_dense_vegetation/nether",
"#c:is_dense_vegetation/end",
{
"id": "#forge:is_dense",
"required": false
Original file line number Diff line number Diff line change
@@ -2,10 +2,7 @@
"values": [
"#c:is_hot/overworld",
"#c:is_hot/nether",
{
"id": "#c:is_hot/end",
"required": false
},
"#c:is_hot/end",
{
"id": "#forge:is_hot",
"required": false
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"values": [
"minecraft:swamp",
"minecraft:mangrove_swamp",
"minecraft:jungle",
"minecraft:bamboo_jungle",
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
{
"values": [
"#c:is_sparse_vegetation/overworld",
{
"id": "#c:is_sparse_vegetation/nether",
"required": false
},
{
"id": "#c:is_sparse_vegetation/end",
"required": false
},
"#c:is_sparse_vegetation/nether",
"#c:is_sparse_vegetation/end",
{
"id": "#forge:is_sparse_vegetation",
"required": false
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"values": [
"#c:is_temperate/overworld",
"#c:is_temperate/nether",
"#c:is_temperate/end"
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"values": []
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"values": []
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"values": [
"minecraft:plains",
"minecraft:sunflower_plains",
"minecraft:forest",
"minecraft:flower_forest",
"minecraft:birch_forest",
"minecraft:old_growth_birch_forest",
"minecraft:dark_forest",
"minecraft:cherry_grove",
"minecraft:meadow",
"minecraft:swamp",
"minecraft:beach",
"minecraft:ocean",
"minecraft:deep_ocean"
]
}
10 changes: 2 additions & 8 deletions src/generated/resources/data/c/tags/worldgen/biome/is_wet.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
{
"values": [
"#c:is_wet/overworld",
{
"id": "#c:is_wet/nether",
"required": false
},
{
"id": "#c:is_wet/end",
"required": false
},
"#c:is_wet/nether",
"#c:is_wet/end",
{
"id": "#forge:is_wet",
"required": false
9 changes: 9 additions & 0 deletions src/main/java/net/neoforged/neoforge/common/Tags.java
Original file line number Diff line number Diff line change
@@ -550,6 +550,10 @@ public static class Items {
public static final TagKey<Item> ORES_IN_GROUND_STONE = tag("ores_in_ground/stone");
public static final TagKey<Item> PLAYER_WORKSTATIONS_CRAFTING_TABLES = tag("player_workstations/crafting_tables");
public static final TagKey<Item> PLAYER_WORKSTATIONS_FURNACES = tag("player_workstations/furnaces");
/**
* All kinds of potion items that can hold various effects including splash and lingering potions from vanilla.
*/
public static final TagKey<Item> POTIONS = tag("potions");
public static final TagKey<Item> RAW_MATERIALS = tag("raw_materials");
public static final TagKey<Item> RAW_MATERIALS_COPPER = tag("raw_materials/copper");
public static final TagKey<Item> RAW_MATERIALS_GOLD = tag("raw_materials/gold");
@@ -887,6 +891,11 @@ public static class Biomes {
public static final TagKey<Biome> IS_COLD_NETHER = tag("is_cold/nether");
public static final TagKey<Biome> IS_COLD_END = tag("is_cold/end");

public static final TagKey<Biome> IS_TEMPERATE = tag("is_temperate");
public static final TagKey<Biome> IS_TEMPERATE_OVERWORLD = tag("is_temperate/overworld");
public static final TagKey<Biome> IS_TEMPERATE_NETHER = tag("is_temperate/nether");
public static final TagKey<Biome> IS_TEMPERATE_END = tag("is_temperate/end");

public static final TagKey<Biome> IS_SPARSE_VEGETATION = tag("is_sparse_vegetation");
public static final TagKey<Biome> IS_SPARSE_VEGETATION_OVERWORLD = tag("is_sparse_vegetation/overworld");
public static final TagKey<Biome> IS_SPARSE_VEGETATION_NETHER = tag("is_sparse_vegetation/nether");
Original file line number Diff line number Diff line change
@@ -35,7 +35,6 @@ protected void addTags(HolderLookup.Provider lookupProvider) {
tag(Tags.Biomes.IS_OVERWORLD).addTags(BiomeTags.IS_OVERWORLD);

tag(Tags.Biomes.IS_HOT_OVERWORLD)
.add(Biomes.SWAMP)
.add(Biomes.MANGROVE_SWAMP)
.add(Biomes.JUNGLE)
.add(Biomes.BAMBOO_JUNGLE)
@@ -56,7 +55,7 @@ protected void addTags(HolderLookup.Provider lookupProvider) {
.add(Biomes.SOUL_SAND_VALLEY)
.add(Biomes.BASALT_DELTAS);
tag(Tags.Biomes.IS_HOT_END);
tag(Tags.Biomes.IS_HOT).addTag(Tags.Biomes.IS_HOT_OVERWORLD).addTag(Tags.Biomes.IS_HOT_NETHER).addOptionalTag(Tags.Biomes.IS_HOT_END.location());
tag(Tags.Biomes.IS_HOT).addTag(Tags.Biomes.IS_HOT_OVERWORLD).addTag(Tags.Biomes.IS_HOT_NETHER).addTag(Tags.Biomes.IS_HOT_END);

tag(Tags.Biomes.IS_COLD_OVERWORLD)
.add(Biomes.TAIGA)
@@ -86,7 +85,25 @@ protected void addTags(HolderLookup.Provider lookupProvider) {
.add(Biomes.END_MIDLANDS)
.add(Biomes.END_HIGHLANDS)
.add(Biomes.END_BARRENS);
tag(Tags.Biomes.IS_COLD).addTag(Tags.Biomes.IS_COLD_OVERWORLD).addOptionalTag(Tags.Biomes.IS_COLD_NETHER.location()).addTag(Tags.Biomes.IS_COLD_END);
tag(Tags.Biomes.IS_COLD).addTag(Tags.Biomes.IS_COLD_OVERWORLD).addTag(Tags.Biomes.IS_COLD_NETHER).addTag(Tags.Biomes.IS_COLD_END);

tag(Tags.Biomes.IS_TEMPERATE_OVERWORLD)
.add(Biomes.PLAINS)
.add(Biomes.SUNFLOWER_PLAINS)
.add(Biomes.FOREST)
.add(Biomes.FLOWER_FOREST)
.add(Biomes.BIRCH_FOREST)
.add(Biomes.OLD_GROWTH_BIRCH_FOREST)
.add(Biomes.DARK_FOREST)
.add(Biomes.CHERRY_GROVE)
.add(Biomes.MEADOW)
.add(Biomes.SWAMP)
.add(Biomes.BEACH)
.add(Biomes.OCEAN)
.add(Biomes.DEEP_OCEAN);
tag(Tags.Biomes.IS_TEMPERATE_NETHER);
tag(Tags.Biomes.IS_TEMPERATE_END);
tag(Tags.Biomes.IS_TEMPERATE).addTag(Tags.Biomes.IS_TEMPERATE_OVERWORLD).addTag(Tags.Biomes.IS_TEMPERATE_NETHER).addTag(Tags.Biomes.IS_TEMPERATE_END);

tag(Tags.Biomes.IS_SPARSE_VEGETATION_OVERWORLD)
.add(Biomes.WOODED_BADLANDS)
@@ -102,7 +119,7 @@ protected void addTags(HolderLookup.Provider lookupProvider) {
.add(Biomes.FROZEN_PEAKS);
tag(Tags.Biomes.IS_SPARSE_VEGETATION_NETHER);
tag(Tags.Biomes.IS_SPARSE_VEGETATION_END);
tag(Tags.Biomes.IS_SPARSE_VEGETATION).addTag(Tags.Biomes.IS_SPARSE_VEGETATION_OVERWORLD).addOptionalTag(Tags.Biomes.IS_SPARSE_VEGETATION_NETHER.location()).addOptionalTag(Tags.Biomes.IS_SPARSE_VEGETATION_END.location());
tag(Tags.Biomes.IS_SPARSE_VEGETATION).addTag(Tags.Biomes.IS_SPARSE_VEGETATION_OVERWORLD).addTag(Tags.Biomes.IS_SPARSE_VEGETATION_NETHER).addTag(Tags.Biomes.IS_SPARSE_VEGETATION_END);

tag(Tags.Biomes.IS_DENSE_VEGETATION_OVERWORLD)
.add(Biomes.DARK_FOREST)
@@ -113,7 +130,7 @@ protected void addTags(HolderLookup.Provider lookupProvider) {
.add(Biomes.MANGROVE_SWAMP);
tag(Tags.Biomes.IS_DENSE_VEGETATION_NETHER);
tag(Tags.Biomes.IS_DENSE_VEGETATION_END);
tag(Tags.Biomes.IS_DENSE_VEGETATION).addTag(Tags.Biomes.IS_DENSE_VEGETATION_OVERWORLD).addOptionalTag(Tags.Biomes.IS_DENSE_VEGETATION_NETHER.location()).addOptionalTag(Tags.Biomes.IS_DENSE_VEGETATION_END.location());
tag(Tags.Biomes.IS_DENSE_VEGETATION).addTag(Tags.Biomes.IS_DENSE_VEGETATION_OVERWORLD).addTag(Tags.Biomes.IS_DENSE_VEGETATION_NETHER).addTag(Tags.Biomes.IS_DENSE_VEGETATION_END);

tag(Tags.Biomes.IS_WET_OVERWORLD)
.add(Biomes.SWAMP)
@@ -126,7 +143,7 @@ protected void addTags(HolderLookup.Provider lookupProvider) {
.add(Biomes.DRIPSTONE_CAVES);
tag(Tags.Biomes.IS_WET_NETHER);
tag(Tags.Biomes.IS_WET_END);
tag(Tags.Biomes.IS_WET).addTag(Tags.Biomes.IS_WET_OVERWORLD).addOptionalTag(Tags.Biomes.IS_WET_NETHER.location()).addOptionalTag(Tags.Biomes.IS_WET_END.location());
tag(Tags.Biomes.IS_WET).addTag(Tags.Biomes.IS_WET_OVERWORLD).addTag(Tags.Biomes.IS_WET_NETHER).addTag(Tags.Biomes.IS_WET_END);

tag(Tags.Biomes.IS_DRY_OVERWORLD)
.add(Biomes.DESERT)
Original file line number Diff line number Diff line change
@@ -196,6 +196,7 @@ public void addTags(HolderLookup.Provider lookupProvider) {
copy(Tags.Blocks.ORES_IN_GROUND_STONE, Tags.Items.ORES_IN_GROUND_STONE);
copy(Tags.Blocks.PLAYER_WORKSTATIONS_CRAFTING_TABLES, Tags.Items.PLAYER_WORKSTATIONS_CRAFTING_TABLES);
copy(Tags.Blocks.PLAYER_WORKSTATIONS_FURNACES, Tags.Items.PLAYER_WORKSTATIONS_FURNACES);
tag(Tags.Items.POTIONS).add(Items.POTION, Items.SPLASH_POTION, Items.LINGERING_POTION);
tag(Tags.Items.RAW_MATERIALS).addTags(Tags.Items.RAW_MATERIALS_COPPER, Tags.Items.RAW_MATERIALS_GOLD, Tags.Items.RAW_MATERIALS_IRON);
tag(Tags.Items.RAW_MATERIALS_COPPER).add(Items.RAW_COPPER);
tag(Tags.Items.RAW_MATERIALS_GOLD).add(Items.RAW_GOLD);
Original file line number Diff line number Diff line change
@@ -274,6 +274,7 @@ protected void addTranslations() {
add(Tags.Items.ORES_IN_GROUND_STONE, "Stone Ores In Ground");
add(Tags.Items.PLAYER_WORKSTATIONS_CRAFTING_TABLES, "Crafting Tables");
add(Tags.Items.PLAYER_WORKSTATIONS_FURNACES, "Furnaces");
add(Tags.Items.POTIONS, "Potions");
add(Tags.Items.RAW_MATERIALS, "Raw Materials");
add(Tags.Items.RAW_MATERIALS_COPPER, "Copper Raw Materials");
add(Tags.Items.RAW_MATERIALS_GOLD, "Gold Raw Materials");
@@ -384,6 +385,10 @@ protected void addTranslations() {
add(Tags.Biomes.IS_COLD_OVERWORLD, "Cold Overworld");
add(Tags.Biomes.IS_COLD_NETHER, "Cold Nether");
add(Tags.Biomes.IS_COLD_END, "Cold End");
add(Tags.Biomes.IS_TEMPERATE, "Temperate");
add(Tags.Biomes.IS_TEMPERATE_OVERWORLD, "Temperate Overworld");
add(Tags.Biomes.IS_TEMPERATE_NETHER, "Temperate Nether");
add(Tags.Biomes.IS_TEMPERATE_END, "Temperate End");
add(Tags.Biomes.IS_SPARSE_VEGETATION, "Sparse Vegetation");
add(Tags.Biomes.IS_SPARSE_VEGETATION_OVERWORLD, "Sparse Overworld Vegetation");
add(Tags.Biomes.IS_SPARSE_VEGETATION_NETHER, "Sparse Nether Vegetation");