refactor: Extract all metadata queries used into a separate resource. #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus we avoid the (nice) JDK 17 string literals and (ugly) String concatenations. In addition it could open up the possibility to have several variants of those, for past and future Neo4j versions. Properties format has been chosen because it's one of the easiest to read without dependencies. XML would be another option, but that would actually but more weight in on GraalVM native image or the module path. Adding libraries for JSON or YAML is not worth the additional weight for this.
ConorNeo
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus we avoid the (nice) JDK 17 string literals and (ugly) String concatenations.
In addition it could open up the possibility to have several variants of those, for past and future Neo4j versions.
Properties format has been chosen because it's one of the easiest to read without dependencies.
XML would be another option, but that would actually but more weight in on GraalVM native image or the module path.
Adding libraries for JSON or YAML is not worth the additional weight for this.